[KMS] Enabling Terraform tests for KMS. #7026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
terraform_kms_tests
branch
from
70201dc to
26b4940
Compare
ghost
changed the title
dominikschubert
approved these changes
Oct 17, 2022
Member
dominikschubert
left a comment
dominikschubert
left a comment
There was a problem hiding this comment.
minor nit, otherwise LGTM 👍
Love the additional comments 👍
ghost
force-pushed
the
terraform_kms_tests
branch
from
26b4940 to
35d17ee
Compare
cmoralesmx
pushed a commit
to cmoralesmx/localstack
that referenced
this pull request
Oct 24, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our test suite executes tests that exactly match the names specified in the
tests/terraform/terraform-tests.yaml. The current config lists list names of test bundles instead of tests themselves, so no tests match those names, nothing gets executed.This PR lists full names of the tests instead.