Skip to content

Remove bson dependency and use pymongo #7022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dfangl merged 3 commits into from
Oct 14, 2022
Merged

Remove bson dependency and use pymongo #7022

dfangl merged 3 commits into from
Oct 14, 2022

Conversation

@calvernaz
Copy link
Contributor

@calvernaz calvernaz commented Oct 14, 2022 •
edited
Loading

This PR removes bson direct dependency and adds pymongo as a dependency that in turn brings a compatible transitive bson dependency.

@calvernaz calvernaz temporarily deployed to localstack-ext-tests October 14, 2022 07:20 Inactive
@calvernaz calvernaz marked this pull request as draft October 14, 2022 07:20
@calvernaz calvernaz temporarily deployed to localstack-ext-tests October 14, 2022 07:23 Inactive
@calvernaz calvernaz requested review from ackdav and dfangl October 14, 2022 07:32
@calvernaz calvernaz temporarily deployed to localstack-ext-tests October 14, 2022 07:44 Inactive
@github-actions
Copy link

github-actions bot commented Oct 14, 2022

LocalStack integration with Pro

       3 files  ±0         3 suites  ±0   1h 25m 57s ⏱️ + 11m 31s
1 409 tests ±0  1 226 ✔️ ±0  183 💤 ±0  0 ❌ ±0 
2 007 runs  ±0  1 592 ✔️ ±0  415 💤 ±0  0 ❌ ±0 

Results for commit 1d9a713. ± Comparison against base commit bc6f7f7.

@calvernaz calvernaz marked this pull request as ready for review October 14, 2022 09:24
ackdav
ackdav approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@ackdav ackdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dfangl dfangl merged commit 420ddee into master Oct 14, 2022
@dfangl dfangl deleted the fix-pymongo-bson-dependencies branch October 14, 2022 10:02
cmoralesmx pushed a commit to cmoralesmx/localstack that referenced this pull request Oct 24, 2022
@calvernaz @cmoralesmx
remove bson dependency and use pymongo (localstack#7022)
215c503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ackdav ackdav ackdav approved these changes

@dfangl dfangl dfangl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@calvernaz @ackdav @dfangl