Add error message for invalid SQS batch message IDs #7015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whummer
requested review from
dfangl,
dominikschubert and
thrau
as code owners
whummer
changed the title
whummer
changed the title
whummer
changed the title
thrau
approved these changes
Oct 13, 2022
Member
thrau
left a comment
thrau
left a comment
There was a problem hiding this comment.
LGTM! just a minor comment regarding the test. no need to change it now, but maybe we can use parameterization for future tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error response for invalid SQS batch message IDs (AWS parity).
This small issue surfaced when running some experiments in "hybrid mode" against real AWS (pointing Lambda event source listeners at an SQS queue in real AWS) - we were basically passing the
ReceiptHandlefor the message ID on batch deletion in the event source listener.Also added a small snapshot test to cover this functionality. The PR adds a snapshot transformer to remove the
Detailsection of returned error responses - could be useful for some of the otherskip_snapshot_verifymarked tests as well.. 👍 (perhaps could be turned into a fixture, to simplify things a bit..). @thrau @dominikschubert