Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Fix: Update Dev Run to mount plux.ini instead of entry_points.txt for localstack dependencies#13708

Merged
thrau merged 2 commits intomainfrom
aidehn/fix/mount-entrypoints-for-dev
Feb 6, 2026
Merged

Fix: Update Dev Run to mount plux.ini instead of entry_points.txt for localstack dependencies#13708
thrau merged 2 commits intomainfrom
aidehn/fix/mount-entrypoints-for-dev

Conversation

@aidehn
Copy link
Copy Markdown
Contributor

@aidehn aidehn commented Feb 6, 2026

Changes + Motivation

Co-Authored by: @bentsku

  • When testing OpenSearch against localstack running in a container I noticed that it wasn't mounting the updated plux.ini changes when using --mount-entrypoints since it was still looking for the entry_points.txt file and mounting that instead.
  • The code has now been updated to add the plux.ini file.
  • Still will look for entry_points.txt for dependencies that aren't localstack_core and localstack_ext keeping the old behavior for these cases.

@aidehn aidehn requested review from alexrashed and bentsku February 6, 2026 03:47
@aidehn aidehn changed the title Fix: Update Dev Run to mount plux.ini instead of entry_points.txt Fix: Update Dev Run to mount plux.ini instead of entry_points.txt for localstack dependencies Feb 6, 2026
@aidehn aidehn added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 6, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 17s ⏱️ +5s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 7550070. ± Comparison against base commit d32e212.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 2s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7550070. ± Comparison against base commit d32e212.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 38m 12s ⏱️ - 2m 4s
5 617 tests ±0  5 096 ✅ ±0  521 💤 ±0  0 ❌ ±0 
5 623 runs  ±0  5 096 ✅ ±0  527 💤 ±0  0 ❌ ±0 

Results for commit 7550070. ± Comparison against base commit d32e212.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 6, 2026

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 54m 30s ⏱️ - 5m 37s
5 196 tests ±0  4 845 ✅ ±0  351 💤 ±0  0 ❌ ±0 
5 198 runs  ±0  4 845 ✅ ±0  353 💤 ±0  0 ❌ ±0 

Results for commit 7550070. ± Comparison against base commit d32e212.

bentsku
bentsku reviewed Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! This is gonna be really practical, thanks for opening the PR 🙏

Just a comment about the docstring that is a bit outdated now, added a suggestion, not sure if @alexrashed wants to comment on it?

Also saw that Alex is out, will ask for a check of @thrau 👍

@bentsku bentsku requested a review from thrau February 6, 2026 11:25
thrau
thrau approved these changes Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@thrau thrau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes look good to me, thanks @aidehn ! thanks also for keeping the old behavior for other libraries 👍

agree with ben that the docstrings could be updated.

@bentsku
Copy link
Copy Markdown
Contributor

bentsku commented Feb 6, 2026 •
edited
Loading

thanks also for keeping the old behavior for other libraries and localstack-pro for now 👍

agree with ben that the docstrings could be updated. i suppose we're going to update this again soon when we update localstack-pro

@thrau this has already been done for pro, right? this PR also updates that behavior. Or do you mean another change?

@thrau
Copy link
Copy Markdown
Member

thrau commented Feb 6, 2026

@thrau this has already been done for pro, right? this PR also updates that behavior. Or do you mean another change?

right! updated my comment :-)

@thrau thrau merged commit 3d25169 into main Feb 6, 2026
13 of 14 checks passed
@thrau thrau deleted the aidehn/fix/mount-entrypoints-for-dev branch February 6, 2026 11:46
@bentsku bentsku mentioned this pull request Feb 6, 2026
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexrashed alexrashed Awaiting requested review from alexrashed

2 more reviewers

@bentsku bentsku bentsku left review comments

@thrau thrau thrau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aidehn @bentsku @thrau