This repository was archived by the owner on Mar 23, 2026. It is now read-only.
testing: avoid installing service dependencies in runners if unnecessary #13701
Merged
testing: avoid installing service dependencies in runners if unnecessary #13701
Conversation
bentsku
added
semver: patch
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 39m 29s ⏱️ Results for commit b6fc84c. |
bentsku
requested review from
alexrashed,
dominikschubert,
k-a-il and
silv-io
as code owners
alexrashed
approved these changes
Feb 4, 2026
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Good catch and a nice cleanup! 🧹 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When working with the LocalStack dev run utility (
localstack.dev.run) and running OpenSearch tests together with @aidehn, we've realized that the test runner was installing the service lazy-loaded dependencies, even though we were running the tests against an external instance.This PR changes the logic to skip installing those dependencies if they don't need to be. This will allow us to gain time in setups where we run the tests against external instances, and avoid local issues when the external dependencies are not runnable on certain types of host like macOS.
Additionally, I've made some test configuration flags more explicit by declaring them in
testing.config, because they were not very easily discoverable, especially theTEST_SKIP_START_LOCALSTACKwhich is really handy.Changes
Tests
Related