This repository was archived by the owner on Mar 23, 2026. It is now read-only.
CloudFormation: make test_fn_find_in_map_with_nested_ref_change_mapping region-agnostic#13700
Merged
CloudFormation: make test_fn_find_in_map_with_nested_ref_change_mapping region-agnostic#13700
Conversation
nik-localstack
requested review from
dominikschubert,
pinzon and
simonrw
as code owners
nik-localstack
added
aws:cloudformation
…ng region-agnostic
nik-localstack
force-pushed
the
cfn/fix-ma-mr-pipeline
branch
from
010411a to
0f8a6f6
Compare
LocalStack Community integration with Pro 2 files 2 suites 31m 24s ⏱️ Results for commit 0f8a6f6. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 43m 43s ⏱️ Results for commit 0f8a6f6. |
Test Results - Alternative Providers585 tests 322 ✅ 17m 41s ⏱️ Results for commit 0f8a6f6. |
simonrw
approved these changes
Feb 5, 2026
Contributor
simonrw
left a comment
simonrw
left a comment
There was a problem hiding this comment.
Thanks for fixing this, you are right this is an oversight for this test. I'm surprised it has taken this long to fail!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The test
test_fn_find_in_map_with_nested_ref_change_mappingwas failing in the MA/MR pipeline.The test was hardcoded to use us-east-1 and us-west-2 in its CloudFormation mapping definitions, which caused it to fail when the pipeline selected a different region.
Changes
Replaced hardcoded "us-east-1" and "us-west-2" with the fixture values