Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

APIGW: fix model typing / update custom id logic#13694

Merged
bentsku merged 2 commits intomainfrom
enable-avro-apigw
Feb 6, 2026
Merged

APIGW: fix model typing / update custom id logic#13694
bentsku merged 2 commits intomainfrom
enable-avro-apigw

Conversation

@bentsku
Copy link
Copy Markdown
Contributor

@bentsku bentsku commented Feb 4, 2026

Motivation

Follow-up from #13552, the CaseInsensitiveDict does not deserialize pretty well, so I went ahead and removed the logic around it, it has been plaguing our implementation since a while now, allowing cased values for custom ids even though the Rest API ID is being used as part of host headers, which are case insensitive and lower-case.

Changes

  • update logic around uppercase custom ids for APIGW to raise an exception
  • change typing of REST APIS containers
  • remove patch in Moto

Tests

Related

@bentsku bentsku added this to the 4.14 milestone Feb 4, 2026
@bentsku bentsku self-assigned this Feb 4, 2026
@bentsku bentsku added aws:apigateway Amazon API Gateway semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 3s ⏱️ -1s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c30849c. ± Comparison against base commit ac2f031.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   18m 27s ⏱️ - 1h 40m 30s
1 317 tests  - 3 879  1 236 ✅  - 3 609  81 💤  - 270  0 ❌ ±0 
1 319 runs   - 3 879  1 236 ✅  - 3 609  83 💤  - 270  0 ❌ ±0 

Results for commit c30849c. ± Comparison against base commit ac2f031.

This pull request removes 3881 and adds 2 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_basic.TestAPIGateway ‑ test_create_rest_api_with_invalid_custom_id
tests.aws.services.apigateway.test_apigateway_custom_ids ‑ test_apigateway_invalid_rest_api_custom_id

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ -4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c30849c. ± Comparison against base commit ac2f031.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   35m 28s ⏱️
1 341 tests 1 261 ✅ 80 💤 0 ❌
1 347 runs  1 261 ✅ 86 💤 0 ❌

Results for commit c30849c.

♻️ This comment has been updated with latest results.

@bentsku bentsku marked this pull request as ready for review February 4, 2026 09:44
@bentsku bentsku requested a review from cloutierMat as a code owner February 4, 2026 09:44
@bentsku bentsku requested a review from giograno February 4, 2026 09:44
@bentsku bentsku changed the title APIGW: fix model typing APIGW: fix model typing / update custom id logic Feb 4, 2026
cloutierMat
cloutierMat reviewed Feb 6, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Thanks @bentsku for tackling this and removing some now useless workaround for the bad data! 🎉

@bentsku bentsku merged commit 20cc1b3 into main Feb 6, 2026
41 checks passed
@bentsku bentsku deleted the enable-avro-apigw branch February 6, 2026 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@giograno giograno Awaiting requested review from giograno

1 more reviewer

@cloutierMat cloutierMat cloutierMat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bentsku bentsku

Labels

aws:apigateway Amazon API Gateway docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

2 participants

@bentsku @cloutierMat