Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

SNS: make v2 default provider#13686

Closed
baermat wants to merge 7 commits intomainfrom
sns/v2-make-default
Closed

SNS: make v2 default provider#13686
baermat wants to merge 7 commits intomainfrom
sns/v2-make-default

Conversation

@baermat
Copy link
Copy Markdown
Member

@baermat baermat commented Feb 3, 2026 •
edited
Loading

Motivation

EDIT: due to problems with the rebase, and to reduce complexity overall, this PR is superseded by #13699
This PR finally puts the new SNS v2 provider as default! 🎉
After a discussion with @bentsku , I opted to not go with the squash and rebase approach, but with a regular squash and merge. The history seems more useful than not in this case, because the old version was already partly internalized.
closes PNX-520

Changes

  • move v2 files to default location
  • remove the old provider
  • remove all skips for tests for parity gaps in the old provider
  • enable previously skipped tests for the new provider
  • remove the extra sns v2 step from the pipeline

Tests

Related

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026 •
edited
Loading

Test Results - Preflight, Unit

1 tests   - 23 113   0 ✅  - 21 255   16s ⏱️ - 5m 57s
1 suites ±     0   0 💤  -  1 859 
1 files   ±     0   0 ❌ ±     0   1 🔥 +1 

For more details on these errors, see this check.

Results for commit 7679391. ± Comparison against base commit 26619a9.

This pull request removes 23114 and adds 1 tests. Note that renamed tests count towards both. 
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-add_tags_to_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-delete_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-describe_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-export_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-get_account_configuration]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-get_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-import_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-list_certificates]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-list_tags_for_certificate]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[AcmProvider-AcmApi-put_account_configuration]
…

tests.unit.services.sns.test_sns

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 59m 19s ⏱️ -14s
5 189 tests ±0  4 836 ✅ +38  351 💤  - 40  2 ❌ +2 
5 191 runs  ±0  4 836 ✅ +38  353 💤  - 40  2 ❌ +2 

For more details on these failures, see this check.

Results for commit 7679391. ± Comparison against base commit 26619a9.

♻️ This comment has been updated with latest results.

@baermat baermat self-assigned this Feb 4, 2026
@baermat baermat added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: needed Pull request should be mentioned in the release notes notes: skip Pull request does not have to be mentioned in the release notes and removed notes: needed Pull request should be mentioned in the release notes labels Feb 4, 2026
@baermat baermat changed the title move v2 files to v1, squash approach SNS: make v2 default provider Feb 4, 2026
@baermat baermat force-pushed the sns/v2-make-default branch from 9fbb82d to 7679391 Compare February 4, 2026 10:45
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

Test Results (MA/MR) - Preflight, Unit

1 tests   0 ✅  16s ⏱️
1 suites  0 💤
1 files    0 ❌  1 🔥

For more details on these errors, see this check.

Results for commit 7679391.

@baermat baermat mentioned this pull request Feb 4, 2026
Merged
@baermat baermat closed this Feb 4, 2026
@alexrashed alexrashed deleted the sns/v2-make-default branch March 4, 2026 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexrashed alexrashed Awaiting requested review from alexrashed alexrashed will be requested when the pull request is marked ready for review alexrashed is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert will be requested when the pull request is marked ready for review dominikschubert is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il will be requested when the pull request is marked ready for review k-a-il is a code owner

Assignees

@baermat baermat

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@baermat