Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Route53: Move tagging logic into Provider methods#13606

Merged
aidehn merged 5 commits intomainfrom
aidehn/feat/route53-rgta-integration
Feb 5, 2026
Merged

Route53: Move tagging logic into Provider methods#13606
aidehn merged 5 commits intomainfrom
aidehn/feat/route53-rgta-integration

Conversation

@aidehn
Copy link
Copy Markdown
Contributor

@aidehn aidehn commented Jan 12, 2026 •
edited
Loading

Changes

  • Updated Route53 provider code to move tagging logic into utils on the provider. This is to allow for the behavior to be overwritten in Pro whilst keeping the original implementation of the operations.
  • Added a test for DeleteHostedZone

@aidehn aidehn added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Jan 12, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026 •
edited
Loading

Test Results - Preflight, Unit

23 114 tests  ±0   21 255 ✅ ±0   6m 12s ⏱️ -7s
     1 suites ±0    1 859 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 100926f. ± Comparison against base commit b9b3ca6.

♻️ This comment has been updated with latest results.

@aidehn aidehn force-pushed the aidehn/feat/route53-rgta-integration branch from 26b77ba to 66a1693 Compare January 12, 2026 09:17
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 0s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 100926f. ± Comparison against base commit b9b3ca6.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 39m 39s ⏱️
5 611 tests 5 050 ✅ 561 💤 0 ❌
5 617 runs  5 050 ✅ 567 💤 0 ❌

Results for commit 100926f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 12, 2026 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 59m 28s ⏱️ + 2m 49s
5 190 tests +1  4 799 ✅ +1  391 💤 ±0  0 ❌ ±0 
5 192 runs  +1  4 799 ✅ +1  393 💤 ±0  0 ❌ ±0 

Results for commit 100926f. ± Comparison against base commit b9b3ca6.

♻️ This comment has been updated with latest results.

@aidehn aidehn force-pushed the aidehn/feat/route53-rgta-integration branch 2 times, most recently from c7496c8 to 77c1774 Compare January 14, 2026 11:24
@aidehn aidehn changed the title PoC: Route53 RGTA Integration Route53: Move tagging logic into Provider methods Jan 14, 2026
@aidehn aidehn marked this pull request as ready for review January 14, 2026 15:27
@aidehn aidehn requested review from giograno, k-a-il and viren-nadkarni and removed request for dominikschubert and giograno January 14, 2026 15:27
@aidehn aidehn force-pushed the aidehn/feat/route53-rgta-integration branch from 77c1774 to ed09228 Compare January 15, 2026 11:41
@aidehn aidehn added this to the 4.14 milestone Jan 23, 2026
giograno
giograno approved these changes Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@giograno giograno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

viren-nadkarni
viren-nadkarni approved these changes Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@viren-nadkarni viren-nadkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second @giograno's comment, otherwise looks great 👍

@aidehn aidehn force-pushed the aidehn/feat/route53-rgta-integration branch 3 times, most recently from 6ccaa92 to be8e26a Compare February 4, 2026 07:43
@aidehn aidehn force-pushed the aidehn/feat/route53-rgta-integration branch from be8e26a to 100926f Compare February 5, 2026 06:31
@aidehn aidehn merged commit 72ddf62 into main Feb 5, 2026
42 checks passed
@aidehn aidehn deleted the aidehn/feat/route53-rgta-integration branch February 5, 2026 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@k-a-il k-a-il Awaiting requested review from k-a-il

2 more reviewers

@viren-nadkarni viren-nadkarni viren-nadkarni approved these changes

@giograno giograno giograno approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.14

Development

Successfully merging this pull request may close these issues.

3 participants

@aidehn @viren-nadkarni @giograno