Skip to content

ecs/add service principal #13474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cloutierMat merged 2 commits into from
Dec 9, 2025
Merged

ecs/add service principal #13474

cloutierMat merged 2 commits into from
Dec 9, 2025
+2 −0

Conversation

@cloutierMat
Copy link
Member

@cloutierMat cloutierMat commented Dec 6, 2025

Motivation

Adding service principals for ecs and ecs-task.

Related

relates to UNC-143

@cloutierMat cloutierMat added aws:ecs Amazon Elastic Container Service semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted labels Dec 6, 2025
@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

Test Results - Preflight, Unit

23 000 tests  +111   21 158 ✅ +83   6m 45s ⏱️ +47s
     1 suites ±  0    1 842 💤 +28 
     1 files   ±  0        0 ❌ ± 0 

Results for commit b3ecf79. ± Comparison against base commit 9a9336f.

This pull request removes 1 and adds 112 tests. Note that renamed tests count towards both. 
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[securityhub-rest-json-ConnectorRegistrationsV2]

tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-checkpoint_durable_execution]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-get_durable_execution]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-get_durable_execution_history]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-get_durable_execution_state]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-list_durable_executions_by_function]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-send_durable_execution_callback_failure]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-send_durable_execution_callback_heartbeat]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-send_durable_execution_callback_success]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LambdaProvider-LambdaApi-stop_durable_execution]
tests.unit.aws.api.test_asf_providers ‑ test_provider_signatures[LogsProvider-LogsApi-associate_source_to_s3_table_integration]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 1s ⏱️ +2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit b3ecf79. ± Comparison against base commit 9a9336f.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 33m 45s ⏱️
5 510 tests 4 954 ✅ 556 💤 0 ❌
5 516 runs  4 954 ✅ 562 💤 0 ❌

Results for commit b3ecf79.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 6, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 54m 3s ⏱️ - 3m 44s
5 130 tests +3  4 734 ✅ +2  396 💤 +1  0 ❌ ±0 
5 132 runs  +3  4 734 ✅ +2  398 💤 +1  0 ❌ ±0 

Results for commit b3ecf79. ± Comparison against base commit 9a9336f.

This pull request skips 1 test. 
tests.aws.test_integration.TestIntegration ‑ test_lambda_streams_batch_and_transactions

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat marked this pull request as ready for review December 6, 2025 02:04
@cloutierMat cloutierMat requested a review from a team December 6, 2025 02:04
@cloutierMat cloutierMat assigned cloutierMat and dfangl and unassigned cloutierMat Dec 6, 2025
@cloutierMat cloutierMat added this to the 4.12 milestone Dec 6, 2025
dfangl
dfangl requested changes Dec 9, 2025
View reviewed changes
Copy link
Member

@dfangl dfangl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title says ecs, the PR uses ECR. Which one is correct?

@cloutierMat
Copy link
Member Author

cloutierMat commented Dec 9, 2025

The title says ecs, the PR uses ECR. Which one is correct?

oops! Thanks for the catch. It is indeed for ecs. 😬

@cloutierMat cloutierMat requested a review from dfangl December 9, 2025 19:29
@cloutierMat cloutierMat merged commit 43e8074 into main Dec 9, 2025
42 checks passed
@cloutierMat cloutierMat deleted the ecs/support-repository-credentials branch December 9, 2025 22:17
jiaming2li pushed a commit to jiaming2li/localstack that referenced this pull request Dec 11, 2025
@cloutierMat @jiaming2li
ecs/add service principal (localstack#13474)
c0ad6ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

@dfangl dfangl dfangl approved these changes

Assignees

@dfangl dfangl

Labels

aws:ecs Amazon Elastic Container Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.12

Development

Successfully merging this pull request may close these issues.

4 participants

@cloutierMat @simonrw @dfangl