Skip to content

[SFN][TestState] Fix state context tests MA/MR run failure #13460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cloutierMat merged 4 commits into from
Dec 3, 2025
Merged

[SFN][TestState] Fix state context tests MA/MR run failure #13460

cloutierMat merged 4 commits into from
Dec 3, 2025

Conversation

@tiurin
Copy link
Contributor

@tiurin tiurin commented Dec 3, 2025

Motivation

Fix a test added in #13418

Closes DRG-299.

Changes

Context object constant had a hardcoded us-east-1 region. Adjusts constant to be a template that is modified according to the region fixture value.

Also adding account id replacement according to fixture. Although the test was not failing on account id, such a replacement will cover all MA/MR bases.

Also removes unnecessary roleArn from context object test requests, as a follow-up to #13459, making tests much faster against AWS.

Tests

Related

@tiurin tiurin requested a review from gregfurman December 3, 2025 12:38
@tiurin tiurin added aws:stepfunctions AWS Step Functions semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 3, 2025
@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 889 tests  ±0   21 075 ✅ ±0   6m 21s ⏱️ -22s
     1 suites ±0    1 814 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 04d3433. ± Comparison against base commit 84bdd4a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 04d3433. ± Comparison against base commit 84bdd4a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   21m 12s ⏱️ - 1h 44m 2s
1 703 tests  - 3 401  1 614 ✅  - 3 098  89 💤  - 303  0 ❌ ±0 
1 705 runs   - 3 401  1 614 ✅  - 3 098  91 💤  - 303  0 ❌ ±0 

Results for commit 04d3433. ± Comparison against base commit 84bdd4a.

This pull request removes 3401 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Dec 3, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   40m 5s ⏱️
1 727 tests 1 639 ✅ 88 💤 0 ❌
1 733 runs  1 639 ✅ 94 💤 0 ❌

Results for commit 04d3433.

♻️ This comment has been updated with latest results.

@tiurin tiurin requested a review from gregfurman December 3, 2025 16:00
cloutierMat
cloutierMat reviewed Dec 3, 2025
View reviewed changes
tests/aws/services/stepfunctions/v2/test_state/test_state_context_object.py Outdated
_CONTEXT_OBJECT_FULL: Final[dict] = {
"Execution": {
"Id": "arn:aws:states:us-east-1:123456789012:execution:MyStateMachine:execution-name-12345",
"Id": "arn:aws:states:__region_placeholder__:__account_id_placeholder__:execution:MyStateMachine:execution-name-12345",
Copy link
Member

@cloutierMat cloutierMat Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we be able to get rid of the placeholder and transformer? I think arn:aws:states:::execution:MyStateMachine:execution-name-12345 should just work out of the box 🤔

Copy link
Contributor Author

@tiurin tiurin Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Thank you a lot @cloutierMat! Region and account are not affecting the functionality being tested. Removing them simplifies test setup. 👍

@tiurin @cloutierMat
Remove region and account from context object ARNs
04d3433 
They are not affecting the functionality being tested. Removing them simplifies test setup.

Co-authored-by: Mathieu Cloutier <[email protected]>
@tiurin tiurin requested a review from cloutierMat December 3, 2025 19:00
cloutierMat
cloutierMat approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the extra diligence of re-running the snapshot! 🚀

@cloutierMat cloutierMat merged commit 9bf66b4 into main Dec 3, 2025
63 of 64 checks passed
@cloutierMat cloutierMat deleted the sfn/fix/test-state-context-test-fail-on-mamr-run branch December 3, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@gregfurman gregfurman

Labels

aws:stepfunctions AWS Step Functions docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiurin @gregfurman @cloutierMat