Skip to content

Conversation

@anisaoshafi
Copy link
Contributor

Motivation

Normal function updated doesn't support adding a capacity provider.

Changes

Tests

Related

Companion to https://github.com/localstack/localstack-pro/pull/5705

@anisaoshafi anisaoshafi added aws:lambda AWS Lambda semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test Results - Preflight, Unit

22 686 tests   20 918 ✅  6m 22s ⏱️
     1 suites   1 768 💤
     1 files         0 ❌

Results for commit 46dfd8a.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 19s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 46dfd8a.

@anisaoshafi anisaoshafi added this to the 4.12 milestone Dec 1, 2025
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 7m 21s ⏱️
3 729 tests 3 448 ✅ 281 💤 0 ❌
3 735 runs  3 448 ✅ 287 💤 0 ❌

Results for commit 46dfd8a.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

LocalStack Community integration with Pro

    2 files      2 suites   1h 36m 57s ⏱️
3 705 tests 3 420 ✅ 285 💤 0 ❌
3 707 runs  3 420 ✅ 287 💤 0 ❌

Results for commit 46dfd8a.

if new_mode:
replace_kwargs["tracing_config_mode"] = new_mode

if "CapacityProviderConfig" in request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Do we need to validate whether the capacity provider actually exists? (feel free to separate from this PR)

@anisaoshafi anisaoshafi merged commit ed44fcf into main Dec 2, 2025
56 of 59 checks passed
@anisaoshafi anisaoshafi deleted the more-validations branch December 2, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws:lambda AWS Lambda docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants