Fix version evaluation of boto3 in asf update action #13442
Merged
+18
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silv-io
added
docs: skip
Closed
silv-io
requested review from
alexrashed,
dfangl,
dominikschubert and
k-a-il
as code owners
silv-io
added
the
review: merge when ready
silv-io
deleted the
flc-210-fix-asf-update-action-to-not-assume-that-boto3-and-botocore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Since
botocore==1.41.6,botocoreandboto3don't follow the same versioning scheme anymore.botocoreupdated to 1.41.6 andboto3updated to 1.42.0.It is unclear if that was intentional or not. However, this shows we need to treat the boto3 version like the
awscliversion now and only determine it based on the upgradedbotocoreversion./cc @joe4dev
Changes
Tests
Running the ASF update action from this branch fixes the issue: https://github.com/localstack/localstack/actions/runs/19826844004/job/56802328770
It resulted in the successful ASF update PR #13443 (closed it to start a new one from main)
Related
FLC-210