Pass DockerHub credentials to test containers #13434
Conversation
sannya-singal
added
semver: patch
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 32s ⏱️ Results for commit 805c346. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 42m 36s ⏱️ Results for commit 805c346. ♻️ This comment has been updated with latest results. |
silv-io
left a comment
silv-io
left a comment
There was a problem hiding this comment.
LGTM! Thanks for finding the location where we perform the login. At first, I thought it's not in there because I looked only at where the client is created.
This should be working fine now!
k-a-il
left a comment
k-a-il
left a comment
There was a problem hiding this comment.
Thanks for resolving this issue 💯 I just have a minor question about the S3 tests that I'd like to clarify
Makefile
Outdated
| # TODO: We need node as it's a dependency of the InfraProvisioner at import time, remove when we do not need it anymore | ||
| # g++ is a workaround to fix the JPype1 compile error on ARM Linux "gcc: fatal error: cannot execute ‘cc1plus’" because the test dependencies include the runtime dependencies. | ||
| docker run -e LOCALSTACK_INTERNAL_TEST_COLLECT_METRIC=1 --entrypoint= -v `pwd`/.git:/opt/code/localstack/.git -v `pwd`/requirements-test.txt:/opt/code/localstack/requirements-test.txt -v `pwd`/tests/:/opt/code/localstack/tests/ -v `pwd`/target/:/opt/code/localstack/target/ -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/localstack:/var/lib/localstack \ | ||
| docker run -e LOCALSTACK_INTERNAL_TEST_COLLECT_METRIC=1 -e DOCKERHUB_USERNAME -e DOCKERHUB_PASSWORD --entrypoint= -v `pwd`/.git:/opt/code/localstack/.git -v `pwd`/requirements-test.txt:/opt/code/localstack/requirements-test.txt -v `pwd`/tests/:/opt/code/localstack/tests/ -v `pwd`/target/:/opt/code/localstack/target/ -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/localstack:/var/lib/localstack \ |
There was a problem hiding this comment.
Are these environment variables actually needed for docker-run-tests-s3-only?
If they are needed, we also need to propagate those env varaibles in the step Run S3 Image tests
There was a problem hiding this comment.
Actually, I don't think they are because the S3 only tests won't run services that download Docker images from what I know. /cc @bentsku
|
|
||
| docker-run-tests: ## Initializes the test environment and runs the tests in a docker container | ||
| docker run -e LOCALSTACK_INTERNAL_TEST_COLLECT_METRIC=1 --entrypoint= -v `pwd`/.git:/opt/code/localstack/.git -v `pwd`/requirements-test.txt:/opt/code/localstack/requirements-test.txt -v `pwd`/.test_durations:/opt/code/localstack/.test_durations -v `pwd`/tests/:/opt/code/localstack/tests/ -v `pwd`/dist/:/opt/code/localstack/dist/ -v `pwd`/target/:/opt/code/localstack/target/ -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/localstack:/var/lib/localstack \ | ||
| docker run -e LOCALSTACK_INTERNAL_TEST_COLLECT_METRIC=1 -e DOCKERHUB_USERNAME -e DOCKERHUB_PASSWORD --entrypoint= -v `pwd`/.git:/opt/code/localstack/.git -v `pwd`/requirements-test.txt:/opt/code/localstack/requirements-test.txt -v `pwd`/.test_durations:/opt/code/localstack/.test_durations -v `pwd`/tests/:/opt/code/localstack/tests/ -v `pwd`/dist/:/opt/code/localstack/dist/ -v `pwd`/target/:/opt/code/localstack/target/ -v /var/run/docker.sock:/var/run/docker.sock -v /tmp/localstack:/var/lib/localstack \ |
There was a problem hiding this comment.
TIL about the -e flag passing directly your own env var!
You can also use variables exported to your local environment:
export VAR1=value1 export VAR2=value2 docker run --env VAR1 --env VAR2 ubuntu env | grep VAR VAR1=value1 VAR2=value2When running the command, the Docker CLI client checks the value the variable has in your local environment and passes it to the container. If no = is provided and that variable isn't exported in your local environment, the variable is unset in the container.
Motivation
Fixes docker based tests failing due to missing DockerHub credentials by passing
DOCKERHUB_USERNAMEandDOCKERHUB_PASSWORDenv variables into test containers.Failing run: https://github.com/localstack/localstack/runs/55590416030
Changes
This PR:
DOCKERHUB_USERNAMEandDOCKERHUB_PASSWORDflags to bothdocker-run-testsanddocker-run-tests-s3-onlyThe test-in-docker script in pro is already adapted to pass the docker hub credentials here and the fixture exists that runs the docker login with these creds here.
Related
Fixes FLC-174