Skip to content

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 27, 2025

Motivation

Follow-up from #13423, this PR migrates the rest of the service providers to properly indicates which state container(s) they use.

It migrates the rest of the Community services.

Changes

Migrate the following services to be explicit about their state containers:

Service Store Backend
route53 X X
route53resolver X X
s3control - X
scheduler - X
secretsmanager - X
ses - X
sns v1 X X
sns v2 X -
sqs X -
ssm - X
sts X X
support - X
swf - X
transcribe X X

Tests

Full Pro run ✅: https://github.com/localstack/localstack-pro/actions/runs/19830037292

@bentsku bentsku added this to the 4.12 milestone Nov 27, 2025
@bentsku bentsku self-assigned this Nov 27, 2025
@bentsku bentsku added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results - Preflight, Unit

22 686 tests  ±0   20 918 ✅ ±0   6m 17s ⏱️ -2s
     1 suites ±0    1 768 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 11c7a5e. ± Comparison against base commit ff6e5e0.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results (amd64) - Acceptance

7 tests   5 ✅  3m 23s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 11c7a5e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 13m 7s ⏱️
4 483 tests 4 167 ✅ 316 💤 0 ❌
4 489 runs  4 167 ✅ 322 💤 0 ❌

Results for commit 11c7a5e.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

LocalStack Community integration with Pro

    2 files      2 suites   1h 40m 33s ⏱️
4 459 tests 4 139 ✅ 320 💤 0 ❌
4 461 runs  4 139 ✅ 322 💤 0 ❌

Results for commit 11c7a5e.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the explicit-visitor-next branch 3 times, most recently from 6d04112 to 65231d0 Compare November 28, 2025 19:21
@bentsku bentsku changed the base branch from explicit-visitor to main November 28, 2025 19:25
@bentsku bentsku force-pushed the explicit-visitor-next branch from 65231d0 to 6e3e7f3 Compare December 1, 2025 16:34
Copy link
Member

@giograno giograno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧹

@bentsku bentsku merged commit fd2d108 into main Dec 2, 2025
44 checks passed
@bentsku bentsku deleted the explicit-visitor-next branch December 2, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants