Skip to content

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 27, 2025

Motivation

TBD, stacked on top of #13428

When working on #13428, one new field has been added for HeadObject response named TagCount, only present when the object has at least one tag.

I'll trigger a full run if this doesn't introduce snapshot breakage in CloudFormation tests 👍

Full Community run ✅ : https://github.com/localstack/localstack/actions/runs/19741726647
Green Pro run ✅ : https://github.com/localstack/localstack-pro/actions/runs/19741843130

Changes

  • add the new TagCount field for HeadObject
  • add tests for it and revalidate a few others to be sure

@bentsku bentsku added this to the 4.12 milestone Nov 27, 2025
@bentsku bentsku self-assigned this Nov 27, 2025
@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 27s ⏱️
  544 tests 492 ✅  52 💤 0 ❌
1 088 runs  984 ✅ 104 💤 0 ❌

Results for commit 09af62d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results - Preflight, Unit

22 669 tests  ±0   20 901 ✅ ±0   6m 33s ⏱️ +6s
     1 suites ±0    1 768 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 09af62d. ± Comparison against base commit dcf088a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 28s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 09af62d. ± Comparison against base commit dcf088a.

♻️ This comment has been updated with latest results.

@bentsku bentsku force-pushed the support-s3-create-bucket-tags branch from bceefe0 to d46542a Compare November 27, 2025 16:20
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 41m 17s ⏱️
2 048 tests 1 882 ✅ 166 💤 0 ❌
2 054 runs  1 882 ✅ 172 💤 0 ❌

Results for commit 09af62d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

LocalStack Community integration with Pro

    2 files      2 suites   1h 19m 9s ⏱️
2 024 tests 1 854 ✅ 170 💤 0 ❌
2 026 runs  1 854 ✅ 172 💤 0 ❌

Results for commit 09af62d.

♻️ This comment has been updated with latest results.

Base automatically changed from support-s3-create-bucket-tags to main November 28, 2025 13:08
@bentsku bentsku force-pushed the support-s3-tag-count-head-object branch from 747671c to 09af62d Compare November 28, 2025 15:05
@bentsku bentsku marked this pull request as ready for review November 28, 2025 15:14
@bentsku bentsku requested a review from k-a-il as a code owner November 28, 2025 15:14
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bentsku bentsku merged commit 5cac820 into main Nov 28, 2025
49 checks passed
@bentsku bentsku deleted the support-s3-tag-count-head-object branch November 28, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws:s3 Amazon Simple Storage Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants