S3: add support for Tags in CreateBucket
#13428
Merged
+637
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bentsku
added
aws:s3
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 22s ⏱️ Results for commit d46542a. ♻️ This comment has been updated with latest results. |
bentsku
force-pushed
the
support-s3-create-bucket-tags
branch
from
bceefe0 to
d46542a
Compare
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 1h 41m 1s ⏱️ Results for commit d46542a. |
LocalStack Community integration with Pro 2 files 2 suites 1h 19m 26s ⏱️ Results for commit d46542a. |
k-a-il
approved these changes
Nov 28, 2025
Contributor
k-a-il
left a comment
k-a-il
left a comment
There was a problem hiding this comment.
Looks good, especially thorough integration tests 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When working on #13427, it came to light that S3 added supporting for tagging Bucket at creation time. This PR implements this feature and tests for it.
See the related documentation: https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html#AmazonS3-CreateBucket-request-Tags
Funny enough, it seems there is missing validation on AWS side for duplicate keys, and it returns a 500 internal error, so this snapshot verification is skipped for now.
Changes
Tagsinput forCreateBucket, checks idempotency and validation