Skip to content

S3: fix change in behavior in CreateBucketConfiguration #13427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentsku merged 1 commit into from
Nov 27, 2025
Merged

S3: fix change in behavior in CreateBucketConfiguration #13427

bentsku merged 1 commit into from
Nov 27, 2025
+46 −30

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Nov 27, 2025 •
edited
Loading

Motivation

We got a report that the newer 6.23 Terraform AWS provider version is failing with LocalStack: #13426

This is due to a change in what exceptions are being raised by AWS: previously, if the body contained a CreateBucketConfiguration XML tag, it also needed to have the LocationConstraint tag inside of it. This seems to have change in AWS, probably related to the new addition of the Tags XML tag inside of it: see https://docs.aws.amazon.com/AmazonS3/latest/API/API_CreateBucket.html#AmazonS3-CreateBucket-request-Tags

When trying to revalidate the test against AWS, the exception was not raised anymore, so the logic of the provider has been updated.

There is still more to be done to make the 6.23 AWS provider work with LocalStack, because it requires the new tagging endpoints that are not yet part of our stubs. Some follow-up work will still need to be done.

Changes

  • do not validate that CreateBucketConfiguration must contain LocationConstraint anymore
  • update the tests against AWS

Next up

Support the Tags input value in CreateBucketConfiguration

@bentsku bentsku added this to the 4.12 milestone Nov 27, 2025
@bentsku bentsku self-assigned this Nov 27, 2025
@bentsku bentsku added aws:s3 Amazon Simple Storage Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 27, 2025
@github-actions
Copy link

github-actions bot commented Nov 27, 2025

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 10s ⏱️
  539 tests 487 ✅  52 💤 0 ❌
1 078 runs  974 ✅ 104 💤 0 ❌

Results for commit e0f53fc.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results - Preflight, Unit

22 669 tests  ±0   20 901 ✅ ±0   6m 16s ⏱️ -3s
     1 suites ±0    1 768 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit e0f53fc. ± Comparison against base commit 12934db.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 17s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit e0f53fc. ± Comparison against base commit 12934db.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 42m 22s ⏱️ - 59m 11s
2 043 tests  - 3 306  1 877 ✅  - 2 934  166 💤  - 372  0 ❌ ±0 
2 049 runs   - 3 306  1 877 ✅  - 2 934  172 💤  - 372  0 ❌ ±0 

Results for commit e0f53fc. ± Comparison against base commit 12934db.

This pull request removes 3306 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 20m 20s ⏱️ - 43m 31s
2 019 tests  - 2 956  1 849 ✅  - 2 748  170 💤  - 208  0 ❌ ±0 
2 021 runs   - 2 956  1 849 ✅  - 2 748  172 💤  - 208  0 ❌ ±0 

Results for commit e0f53fc. ± Comparison against base commit 12934db.

This pull request removes 2956 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@bentsku bentsku marked this pull request as ready for review November 27, 2025 13:11
@bentsku bentsku requested a review from k-a-il as a code owner November 27, 2025 13:11
@bentsku bentsku mentioned this pull request Nov 27, 2025
Merged
k-a-il
k-a-il approved these changes Nov 27, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice quick fix, LGTM 👍

@bentsku bentsku merged commit 9e9f65f into main Nov 27, 2025
100 of 101 checks passed
@bentsku bentsku deleted the fix-s3-create-bucket branch November 27, 2025 16:19
@bblommers bblommers mentioned this pull request Nov 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-a-il k-a-il k-a-il approved these changes

Assignees

@bentsku bentsku

Labels

aws:s3 Amazon Simple Storage Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.12

Development

Successfully merging this pull request may close these issues.

3 participants

@bentsku @k-a-il