-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
deprecate starting in host mode via the CLI #13398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 10s ⏱️ Results for commit 5faf6e4. ♻️ This comment has been updated with latest results. |
thrau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I didn't follow the decision, but trust that we went through the appropriate product questions (are we impacting users, are there any important accounts using the feature, and if so how can we migrate them, etc.)
Co-authored-by: Thomas Rausch <[email protected]>
|
Thanks, @thrau! Before pushing for this change, I did check the GitHub search to find usages of the host mode in the CLI. There are only very few actual usages, most of the search results are old forks of our own code or very outdated repos. The remaining usages should be easy to migrate to the Docker mode. 👍🏽 |
silv-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Do we have some telemetry in place to track usage of it going forward? This way we can better judge when to fully remove that option.
Motivation
We decided to finally separate the CLI from the runtime packages, because:
In order to prepare the extraction of the CLI and the decoupling from the runtime, we are deprecating the host mode of the CLI.
In future releases, it will not be possible to run
localstack start --hostanymore and we directly refer users to the default way of executing LocalStack via the CLI (which starts a Docker container).With this PR a prominent deprecation warning is being introduced to warn about these upcoming changes:
Where the
DeprecationWarningon top by Click is red, and the manual deprecation warning below is red and bold.Changes
--hostoption of thestartcommand of the LocalStack CLI.Fixes ENG-138.