Skip to content

Fix DNS port mapping in localstack.dev.kubernetes #13361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nik-localstack merged 1 commit into from
Nov 12, 2025
Merged

Fix DNS port mapping in localstack.dev.kubernetes #13361

nik-localstack merged 1 commit into from
Nov 12, 2025

Conversation

@nik-localstack
Copy link
Contributor

@nik-localstack nik-localstack commented Nov 10, 2025

Motivation

Fixes a bug with localstack.dev.kubernetes not exposing the DNS port properly.
K3d was failing to map both ports, resulting in failures with DNS resolution.

Changes

Replaces two protocol-specific DNS port entries with a single one.

Tests

Following the instructions of this script
python -m localstack.dev.kubernetes --pro --write --expose-dns

And then running pro tests that require DNS should be successful

Related

@nik-localstack nik-localstack self-assigned this Nov 10, 2025
@nik-localstack nik-localstack added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 10, 2025
@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Test Results - Preflight, Unit

22 309 tests  ±0   20 555 ✅ ±0   15m 27s ⏱️ +8s
     1 suites ±0    1 754 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit e384768. ± Comparison against base commit 2c829b6.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 26s ⏱️ -5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit e384768. ± Comparison against base commit 2c829b6.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 40m 43s ⏱️
5 310 tests 4 771 ✅ 539 💤 0 ❌
5 316 runs  4 771 ✅ 545 💤 0 ❌

Results for commit e384768.

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   2h 1m 27s ⏱️ +21s
4 936 tests ±0  4 557 ✅ ±0  379 💤 ±0  0 ❌ ±0 
4 938 runs  ±0  4 557 ✅ ±0  381 💤 ±0  0 ❌ ±0 

Results for commit e384768. ± Comparison against base commit 2c829b6.

@nik-localstack nik-localstack marked this pull request as ready for review November 10, 2025 10:34
@nik-localstack nik-localstack requested a review from a team November 10, 2025 10:34
cloutierMat
cloutierMat approved these changes Nov 10, 2025
View reviewed changes
Copy link
Member

@cloutierMat cloutierMat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious to know where you experienced the issue? I don't see an issue with it, but I was able to start the cluster and pass the tests with both. Is it OS dependant?

@nik-localstack
Copy link
Contributor Author

nik-localstack commented Nov 12, 2025

I am curious to know where you experienced the issue? I don't see an issue with it, but I was able to start the cluster and pass the tests with both. Is it OS dependant?

Could be OS dependant. The dns resolution in tests was hanging for me in the double mapping scenario.

@nik-localstack nik-localstack merged commit f303c15 into main Nov 12, 2025
55 checks passed
@nik-localstack nik-localstack deleted the k8s/dns-ports-script-fix branch November 12, 2025 07:52
@cloutierMat
Copy link
Member

cloutierMat commented Nov 12, 2025

Could be OS dependant. The dns resolution in tests was hanging for me in the double mapping scenario.

Thanks for the extra context. Glad you found a mapping that works for everyone 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cloutierMat cloutierMat cloutierMat approved these changes

Assignees

@nik-localstack nik-localstack

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nik-localstack @cloutierMat