Remove redundant ruff ignores for generated ASF modules #13355
Merged
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purcell
requested review from
alexrashed,
bentsku,
k-a-il,
sannya-singal and
silv-io
as code owners
purcell
added
semver: patch
Contributor
Author
|
Aha, this PR will – of course – need to wait until after the weekly regeneration of the ASF modules. Until then, linting will continue to fail because the existing generated modules are not compliant with these stricter rules. |
alexrashed
approved these changes
Nov 10, 2025
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
The changes are looking good! As soon as #13359 is merged and this PR is rebased upon the updated main, the linting / preflight step in the CI should get 💚 and we can merge this one! Thanks for the cleanup! 🧹 💯
Merged
As of #13347, the type annotations in those modules are modern and will not upset ruff.
purcell
force-pushed
the
remove-ruff-ignores
branch
from
bc85328 to
d0fcd74
Compare
Contributor
Author
|
Rebased. |
Contributor
Author
|
Merging now, since the lint step passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As of #13347, the type annotations in those modules are modern and will not upset ruff.
Changes
Remove per-file ignores for the ASF modules, since they are redundant.
Tests
Running
make format,make lintwithout those ignores present is successful.Related
Mentioned by @giograno in #13347 (comment).