Skip to content

Propose fix two typos #13341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexrashed merged 1 commit into from
Nov 6, 2025
Merged

Propose fix two typos #13341

alexrashed merged 1 commit into from
Nov 6, 2025

Conversation

@jeis4wpi
Copy link
Contributor

@jeis4wpi jeis4wpi commented Nov 5, 2025

Propose fix two typos

is this helpful?

@jeis4wpi jeis4wpi requested a review from alexrashed as a code owner November 5, 2025 20:28
localstack-bot
localstack-bot reviewed Nov 5, 2025
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented Nov 5, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@jeis4wpi
Copy link
Contributor Author

jeis4wpi commented Nov 5, 2025

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Nov 5, 2025
@localstack-bot
@jeis4wpi has signed the CLA in #13341
f66386c
@alexrashed alexrashed added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Nov 6, 2025
@alexrashed alexrashed added this to the 4.11 milestone Nov 6, 2025
alexrashed
alexrashed approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jeis4wpi! Thanks for the contribution! I am a bit surprised that you stumbled over these typos, and the metrics coverage report is really just a script that is used to measure out code coverage and parity. But anyway, every typo fixed is a win! I'll merge it right away! 💯

@alexrashed alexrashed merged commit 5f5a8fb into localstack:main Nov 6, 2025
15 of 19 checks passed
mfurqaan31 pushed a commit to mfurqaan31/localstack that referenced this pull request Nov 6, 2025
@jeis4wpi @mfurqaan31
Propose fix two typos (localstack#13341)
dc1db09 
Signed-off-by: John E <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@alexrashed alexrashed alexrashed approved these changes

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.11

Development

Successfully merging this pull request may close these issues.

3 participants

@jeis4wpi @localstack-bot @alexrashed