CFn: support nested properties in attribute lookup #13304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

simonrw merged 1 commit into main from cfn/nested-sub-properties

Oct 27, 2025

Contributor

simonrw commented Oct 24, 2025 •

edited

Loading

Motivation

A member of the community slack pointed out that the new CloudFormation engine does not correctly support nested attribute lookups with the Fn::Sub intrinsic function. Namely

Value:
    Fn::Sub: "my value ${db.Endpoint.Address}"

to get the address of an RDS db instance.

Changes

If the arguments list in ChangeSetModelPreproc._resolve_attribute have more than 2 parts then assume the 1.. items should be joined with a . and pass to the resolver function

Fixes UNC-75

Testing

This change is tested in the Pro repo as it contains the code needed to deploy an RDS db instance


          Handle nested properties

5ea2f7c

simonrw added semver: patch docs: skip notes: skip labels

github-actions bot commented Oct 24, 2025

Test Results - Preflight, Unit

22 376 tests ±0 20 626 ✅ ±0 16m 3s ⏱️ +40s
1 suites ±0 1 750 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5ea2f7c. ± Comparison against base commit a01a933.

github-actions bot commented Oct 24, 2025

LocalStack Community integration with Pro

2 files ± 0 2 suites ±0 37m 9s ⏱️ - 1h 22m 50s
584 tests - 4 293 470 ✅ - 4 052 114 💤 - 241 0 ❌ ±0
586 runs - 4 293 470 ✅ - 4 052 116 💤 - 241 0 ❌ ±0

Results for commit 5ea2f7c. ± Comparison against base commit a01a933.

This pull request removes 4293 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

github-actions bot commented Oct 24, 2025

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 22s ⏱️ -5s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit 5ea2f7c. ± Comparison against base commit a01a933.

github-actions bot commented Oct 24, 2025

Test Results (amd64) - Integration, Bootstrap

5 files ± 0 5 suites ±0 49m 32s ⏱️ - 1h 49m 6s
608 tests - 4 643 495 ✅ - 4 241 113 💤 - 402 0 ❌ ±0
614 runs - 4 643 495 ✅ - 4 241 119 💤 - 402 0 ❌ ±0

Results for commit 5ea2f7c. ± Comparison against base commit a01a933.

This pull request removes 4643 tests.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

github-actions bot commented Oct 24, 2025

Test Results - Alternative Providers

583 tests - 838 329 ✅ - 439 25m 44s ⏱️ - 15m 13s
1 suites - 4 254 💤 - 399
1 files - 4 0 ❌ ± 0

Results for commit 5ea2f7c. ± Comparison against base commit a01a933.

This pull request removes 838 tests.

tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_basic_operations_multiple_protocols[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_alarm_lambda_target
…

simonrw marked this pull request as ready for review

October 27, 2025 19:53

simonrw requested review from dominikschubert and pinzon as code owners

October 27, 2025 19:53

pinzon approved these changes

View reviewed changes

Member

pinzon left a comment

LGTM 👍

simonrw merged commit 720fa9f into main

69 checks passed

simonrw deleted the cfn/nested-sub-properties branch

October 27, 2025 20:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip notes: skip semver: patch