K8s tests: Add requires_in_process marker in only_localstack tests where needed #13303
Conversation
nik-localstack
added
area: ci
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 7m 52s ⏱️ Results for commit 5ccf644. ♻️ This comment has been updated with latest results. |
Test Results - Preflight, Unit22 376 tests 20 626 ✅ 15m 57s ⏱️ Results for commit 5ccf644. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Acceptance7 tests 5 ✅ 3m 21s ⏱️ Results for commit 5ccf644. ♻️ This comment has been updated with latest results. |
Test Results - Alternative Providers1 149 tests 643 ✅ 30m 54s ⏱️ Results for commit 5ccf644. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 20m 57s ⏱️ Results for commit 5ccf644. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 1h 46m 5s ⏱️ Results for commit 5ccf644. ♻️ This comment has been updated with latest results. |
nik-localstack
force-pushed
the
k8s/run-only-localstack-tests
branch
from
5b271d7 to
2810fae
Compare
nik-localstack
force-pushed
the
k8s/run-only-localstack-tests
branch
from
2810fae to
5ccf644
Compare
nik-localstack
requested review from
alexrashed,
baermat,
dfangl,
dominikschubert,
gregfurman,
joe4dev,
k-a-il,
macnev2013,
pinzon,
silv-io,
thrau and
viren-nadkarni
as code owners
nik-localstack
requested review from
cloutierMat,
maxhoheiser and
simonrw
as code owners
cloutierMat
left a comment
cloutierMat
left a comment
There was a problem hiding this comment.
Thank you for the effort to go through them all! I am glad we can now have a 🟢 pipeline running community test on k8s 🎉
Motivation
We want to run more of our tests in Kubernetes. Adding the marker
requires_in_processto tests that require to run in the same process with LocalStack to be successful will allow us to exclude them from the Kubernetes test suite.related to UNC-69
Changes
markers.requires_in_processin all tests that are failing when running against LS in K8s. These tests are usingmonkeypatchorhttpserverfixtures or trying to access internal state of services which is not possible when running LS in a container.