Skip to content

CFn: Remove deprecated and non-functional deploy GUI tool #13293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinzon merged 1 commit into from
Oct 23, 2025
Merged

CFn: Remove deprecated and non-functional deploy GUI tool #13293

pinzon merged 1 commit into from
Oct 23, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Oct 21, 2025

Motivation

This PR removes the outdated and non-functional CFn deploy GUI tool, which has been broken for months and is no longer maintained. The tool will not be updated, instead the functionality will be reimplemented in a better way within the web platform.

Changes

  • Remove web assets
  • Remove plugins
  • Remove tests related to it

@pinzon pinzon added docs: skip Pull request does not require documentation changes semver: patch Non-breaking changes which can be included in patch releases docs: needed Pull request requires documentation updates notes: skip Pull request does not have to be mentioned in the release notes and removed docs: skip Pull request does not require documentation changes labels Oct 21, 2025
@pinzon pinzon marked this pull request as ready for review October 21, 2025 18:35
@pinzon pinzon added the aws:cloudformation AWS CloudFormation label Oct 21, 2025
@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 365 tests   - 1   20 615 ✅  - 1   15m 51s ⏱️ -9s
     1 suites ±0    1 750 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fb0bc2b. ± Comparison against base commit 06df84d.

This pull request removes 1 test. 
tests.unit.services.cloudformation.test_deploy_ui.TestCloudFormationUiResource ‑ test_get

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   37m 5s ⏱️ - 1h 21m 56s
584 tests  - 4 294  470 ✅  - 4 053  114 💤  - 241  0 ❌ ±0 
586 runs   - 4 294  470 ✅  - 4 053  116 💤  - 241  0 ❌ ±0 

Results for commit fb0bc2b. ± Comparison against base commit 06df84d.

This pull request removes 4294 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 20s ⏱️ -6s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fb0bc2b. ± Comparison against base commit 06df84d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 36s ⏱️
608 tests 495 ✅ 113 💤 0 ❌
614 runs  495 ✅ 119 💤 0 ❌

Results for commit fb0bc2b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

Test Results - Alternative Providers

583 tests   329 ✅  26m 8s ⏱️
  1 suites  254 💤
  1 files      0 ❌

Results for commit fb0bc2b.

♻️ This comment has been updated with latest results.

@pinzon pinzon force-pushed the unc-63-remove-cfn-ui branch from c210432 to fb0bc2b Compare October 21, 2025 20:17
simonrw
simonrw approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up 👍

@pinzon pinzon merged commit a01a933 into main Oct 23, 2025
43 checks passed
@pinzon pinzon deleted the unc-63-remove-cfn-ui branch October 23, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: needed Pull request requires documentation updates notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pinzon @simonrw