Skip to content

Conversation

@nik-localstack
Copy link
Contributor

Motivation

Fix "Publish dev release" step of CI.

After #13193 build python package is no longer part of pyproject.toml dependencies. However, this is needed for make build step

Changes

  • Install build before running python -m build

@nik-localstack nik-localstack self-assigned this Oct 20, 2025
@nik-localstack nik-localstack added area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Oct 20, 2025
@nik-localstack nik-localstack marked this pull request as ready for review October 20, 2025 14:25
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this oversight! Looks good.

@github-actions
Copy link

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 3s ⏱️
  533 tests 481 ✅  52 💤 0 ❌
1 066 runs  962 ✅ 104 💤 0 ❌

Results for commit 65460ee.

@github-actions
Copy link

Test Results - Preflight, Unit

22 363 tests  ±0   20 613 ✅ ±0   15m 33s ⏱️ -13s
     1 suites ±0    1 750 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 65460ee. ± Comparison against base commit b4c510a.

@bentsku
Copy link
Contributor

bentsku commented Oct 20, 2025

Awesome find!
Quick question: it seems this has silently failed and we did not realize it: should we actually fail the pipeline if we cannot publish the dev-release? Not in scope of this PR, but more of a general thought

edit:

/home/runner/work/localstack/localstack/.venv/bin/python: No module named build
make: *** [Makefile:81: dist] Error 1
dev release failed (maybe it is already published)

I can see maybe there are reasons not to

@github-actions
Copy link

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 43s ⏱️ +21s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 65460ee. ± Comparison against base commit b4c510a.

@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 39m 24s ⏱️
5 252 tests 4 737 ✅ 515 💤 0 ❌
5 258 runs  4 737 ✅ 521 💤 0 ❌

Results for commit 65460ee.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

LocalStack Community integration with Pro

    2 files      2 suites   2h 0m 21s ⏱️
4 878 tests 4 523 ✅ 355 💤 0 ❌
4 880 runs  4 523 ✅ 357 💤 0 ❌

Results for commit 65460ee.

@nik-localstack nik-localstack merged commit dcf52d8 into main Oct 21, 2025
130 of 133 checks passed
@nik-localstack nik-localstack deleted the ci/install-build-dependency-on-make-build branch October 21, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci Running LocalStack in CI environments docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants