-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Install build package when running make build #13285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install build package when running make build #13285
Conversation
silv-io
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this oversight! Looks good.
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 8m 3s ⏱️ Results for commit 65460ee. |
|
Awesome find! edit:
I can see maybe there are reasons not to |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 39m 24s ⏱️ Results for commit 65460ee. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files 2 suites 2h 0m 21s ⏱️ Results for commit 65460ee. |
Motivation
Fix "Publish dev release" step of CI.
After #13193
buildpython package is no longer part ofpyproject.tomldependencies. However, this is needed formake buildstepChanges
buildbefore runningpython -m build