Skip to content

Step Functions: fix validate-state-machine-definition #13281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gregfurman merged 5 commits into from
Nov 20, 2025
Merged

Step Functions: fix validate-state-machine-definition #13281

gregfurman merged 5 commits into from
Nov 20, 2025

Conversation

@YukiMichishita
Copy link
Contributor

@YukiMichishita YukiMichishita commented Oct 19, 2025

Motivation

Fixes Step Functions definition validation issues #12958 and #13171. Details and rationale are in the original issues.

Changes

localstack-bot
localstack-bot reviewed Oct 19, 2025
View reviewed changes
Copy link
Contributor

@localstack-bot localstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

@localstack-bot
Copy link
Contributor

localstack-bot commented Oct 19, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@YukiMichishita
Copy link
Contributor Author

YukiMichishita commented Oct 19, 2025

I have read the CLA Document and I hereby sign the CLA

localstack-bot added a commit that referenced this pull request Oct 19, 2025
@localstack-bot
@YukiMichishita has signed the CLA in #13281
25e8f20
@gregfurman gregfurman self-assigned this Oct 20, 2025
@gregfurman gregfurman added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes aws:stepfunctions AWS Step Functions labels Oct 20, 2025
gregfurman
gregfurman approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@gregfurman gregfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the neat contribution (and patience 🙂) on this PR 🚀

Unsure whether this will fix #13171 though, but let's rather discuss on that issue.

@gregfurman gregfurman force-pushed the resolve-issue-12958-13171 branch from fa58564 to a8604e4 Compare November 20, 2025 09:11
@gregfurman gregfurman changed the title Step Functions: fix validate-state-machine-definition for #12958 and #13171 Step Functions: fix validate-state-machine-definition Nov 20, 2025
@gregfurman gregfurman merged commit ae5c685 into localstack:main Nov 20, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@localstack-bot localstack-bot localstack-bot left review comments

@gregfurman gregfurman gregfurman approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

@joe4dev joe4dev Awaiting requested review from joe4dev joe4dev is a code owner

Assignees

@gregfurman gregfurman

Labels

aws:stepfunctions AWS Step Functions docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@YukiMichishita @localstack-bot @gregfurman