Remove verify_ssl = False from in memory localstack test configuration #13275
+0
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-localstack
added
semver: patch
alexrashed
approved these changes
Oct 20, 2025
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
Awesome! Thanks for following up on the discussion in #13234! 💯
nik-localstack
deleted the
remove-ssl-verification-skip-for-inmemory-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up from #13234
The skip of SSL verification was a source of confusion in the past when trying to figure out why a test was failing only on K8s tests pipeline while it was successful in the "in-memory localstack" test execution.
Changes
We remove this configuration. If a test needs to skip SSL validation,this can be done with
verify=Falsein the specificrequestscall like it was done in #13234