Simplify new_tmp_dir #13273
Merged
Simplify new_tmp_dir #13273
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giograno
added
semver: patch
dfangl
approved these changes
Oct 16, 2025
Member
dfangl
left a comment
dfangl
left a comment
There was a problem hiding this comment.
LGTM! Thanks for adding proper typing as well!
| folder = new_tmp_file(dir=dir) | ||
| rm_rf(folder) | ||
| mkdir(folder) | ||
| def new_tmp_dir(dir: str | None = None, mode: int = 0o777) -> str: |
Member
There was a problem hiding this comment.
suggestion: a docstring explaining some of the behavior here would be nice as well. Totally optional though!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR attempts to simplify the logic of the
new_tmp_dirutility functions.The original implementation uses
tempfile.mkstempand first closes the file descriptor of the created file, then removes the created directory, and finally, re-creates it.The new implementation relies on
tempfile.mkdtemp. It also preserves the original behavior by changing the permissions (tempfile.mkdtempwould come with0o700whilemkdirhas0o777).Changes
new_tmp_dirfunction withtempfile.mkdtemp, as explained above.