-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
drop python 3.9 and add tests for 3.14 in the cli #13247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
S3 Image Test Results (AMD64 / ARM64) 2 files 2 suites 9m 1s ⏱️ Results for commit 69a74a0. ♻️ This comment has been updated with latest results. |
d74952f to
90fac46
Compare
Helper Script Tests34 tests 34 ✅ 0s ⏱️ Results for commit 69a74a0. ♻️ This comment has been updated with latest results. |
90fac46 to
69a74a0
Compare
thrau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I think it's relatively safe to drop 3.9 at this point, although we don't know exactly whether we will bother some users, given it's EOL and users are encouraged by python to upgrade to 3.10, there's no good reason we should continue to support it.
dfangl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I agree, dropping python 3.9 for new versions should be fine!
Motivation
Python 3.9 has its EOL with October 2025, which is why we should be dropping support for 3.9 and add tests for the newly released 3.14 with the next release of LocalStack (scheduled for the end of October).
Changes