Fix Event Bridge input transformation of booleans by carole-lavillonniere · Pull Request #13236 · localstack/localstack

carole-lavillonniere · 2025-10-07T13:59:19Z

Motivation

While testing Event Bridge input transformation, realized boolean values were not properly rendered.

Localstack was formatting them with an upper case True and False but AWS formats them as true and false.

Changes

Added a special case for boolean values in the placeholder substitution code and added a parity test case.

github-actions · 2025-10-07T14:02:11Z

Test Results - Preflight, Unit

22 298 tests ±0 20 555 ✅ ±0 15m 24s ⏱️ -17s
1 suites ±0 1 743 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit b96ac19. ± Comparison against base commit 9af2464.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-07T15:25:41Z

LocalStack Community integration with Pro

2 files ± 0 2 suites ±0 58m 13s ⏱️ - 1h 0m 5s
2 653 tests - 2 154 2 545 ✅ - 1 925 108 💤 - 229 0 ❌ ±0
2 655 runs - 2 154 2 545 ✅ - 1 925 110 💤 - 229 0 ❌ ±0

Results for commit b96ac19. ± Comparison against base commit 9af2464.

This pull request removes 2156 and adds 2 tests. Note that renamed tests count towards both.

tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApigatewayIntegration ‑ test_create_integration_with_vpc_link
tests.aws.services.events.test_events_inputs.TestInputTransformer ‑ test_input_transformer_nested_keys_replacement["Command is <valid>!"]

♻️ This comment has been updated with latest results.

carole-lavillonniere · 2025-10-08T11:12:55Z

+      "call": 1.27,
+      "teardown": 1.23,
+      "total": 2.5
+    }


Not sure why durations_in_seconds was added everywhere. Was the feature added after 2024-05-13?

Yes, the time tracking for test validations was added as of few months ago - thanks to @tiurin ⏲️.
The purpose of it was to use that data to track slow tests or slow services overall.

Context PR here: #12638

carole-lavillonniere · 2025-10-08T11:31:02Z

+          "MessageId": "<uuid:1>",
+          "ReceiptHandle": "<receipt-handle:1>",
+          "MD5OfBody": "<m-d5-of-body:1>",
+          "Body": "\"Command is true!\""


Localstack used to give back "Body": "\"Command is True!\""

github-actions · 2025-10-08T12:03:08Z

Test Results (amd64) - Acceptance

7 tests ±0 5 ✅ ±0 3m 20s ⏱️ -1s
1 suites ±0 2 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit b96ac19. ± Comparison against base commit 9af2464.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-08T12:05:05Z

Test Results - Alternative Providers

380 tests 248 ✅ 3m 51s ⏱️
1 suites 132 💤
1 files 0 ❌

Results for commit b96ac19.

♻️ This comment has been updated with latest results.

github-actions · 2025-10-08T12:20:14Z

Test Results (amd64) - Integration, Bootstrap

5 files 5 suites 1h 25m 46s ⏱️
2 677 tests 2 572 ✅ 105 💤 0 ❌
2 683 runs 2 572 ✅ 111 💤 0 ❌

Results for commit b96ac19.

♻️ This comment has been updated with latest results.

bentsku

LGTM! Nice and neat fix! Thanks a lot for jumping on this, adding the snapshot validated test case and re-validating other tests against AWS 🚀

I only have one minor dict regarding the docstring format, but once addressed this is good to merge!
I'll already approve the PR as this only relates to a docstring, but it would be nice to get it addressed before merging if possible 🙏

bentsku · 2025-10-08T12:10:50Z

+        The transformed string with placeholders replaced by values from `replacements`.
+    """
+    ...
+    is_json_template = template.strip().startswith("{")


praise: I think this is a nice change to keep the logic encapsulated, as only replace_template_placeholders needed that information. Thanks for making this nicer 👍

bentsku · 2025-10-08T12:27:04Z

+    """
+    Replaces placeholders in an EventBridge-style InputTemplate string.
+
+    Args:
+        template: The template string containing placeholders like <$.foo.bar>.
+        replacements: A dict providing values to fill in.
+
+    Returns:
+        The transformed string with placeholders replaced by values from `replacements`.
+    """


nit: thanks for adding more detailed docstring! we do not use the Google docstring format inside our codebase, and we use Sphinx: https://sphinx-rtd-tutorial.readthedocs.io/en/latest/docstrings.html

This would look like:

""" Replaces placeholders in an EventBridge-style InputTemplate string. :param template: The template string containing placeholders like <$.foo.bar>. :param replacements: A dict providing values to fill in. :return: The transformed string with placeholders replaced by values from `replacements`. """

If you could update for coherence before merging, this would be awesome 👍

Thanks for the info! Addressed b96ac19

carole-lavillonniere force-pushed the extract-events-input-transformation branch 2 times, most recently from 91ac4a2 to f108cbf Compare October 8, 2025 09:27

carole-lavillonniere changed the title ~~Fix Event Bridge input transformation~~ Fix Event Bridge input transformation of booleans Oct 8, 2025

carole-lavillonniere force-pushed the extract-events-input-transformation branch from f108cbf to 1198117 Compare October 8, 2025 11:11

carole-lavillonniere commented Oct 8, 2025

View reviewed changes

carole-lavillonniere added aws:events Amazon EventBridge type: bug Bug report labels Oct 8, 2025

carole-lavillonniere commented Oct 8, 2025

View reviewed changes

fix bool input transformation in eventbridge

be0f580

carole-lavillonniere force-pushed the extract-events-input-transformation branch from 1198117 to be0f580 Compare October 8, 2025 11:35

carole-lavillonniere marked this pull request as ready for review October 8, 2025 11:37

carole-lavillonniere requested review from bentsku and maxhoheiser as code owners October 8, 2025 11:37

bentsku approved these changes Oct 8, 2025

View reviewed changes

change docstring format from google to sphinx

b96ac19

carole-lavillonniere merged commit 658d6fb into main Oct 8, 2025
40 checks passed

carole-lavillonniere deleted the extract-events-input-transformation branch October 8, 2025 19:39

baermat pushed a commit that referenced this pull request Oct 13, 2025

Fix Event Bridge input transformation of booleans (#13236)

a092ed9

Uh oh!

Conversation

carole-lavillonniere commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results - Preflight, Unit

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

LocalStack Community integration with Pro

Uh oh!

carole-lavillonniere Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anisaoshafi Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

anisaoshafi Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

carole-lavillonniere Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (amd64) - Acceptance

Uh oh!

github-actions bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results - Alternative Providers

Uh oh!

github-actions bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results (amd64) - Integration, Bootstrap

Uh oh!

bentsku left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bentsku Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

bentsku Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

carole-lavillonniere Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

carole-lavillonniere commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading

carole-lavillonniere Oct 8, 2025 •

edited

Loading

github-actions bot commented Oct 8, 2025 •

edited

Loading

github-actions bot commented Oct 8, 2025 •

edited

Loading

github-actions bot commented Oct 8, 2025 •

edited

Loading

bentsku left a comment •

edited

Loading