Skip to content

add sqs tests for ApproximateNumberOfMessagesNotVisible queue attribute #13197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thrau merged 2 commits into from
Sep 26, 2025
Merged

add sqs tests for ApproximateNumberOfMessagesNotVisible queue attribute #13197

thrau merged 2 commits into from
Sep 26, 2025

Conversation

@thrau
Copy link
Member

@thrau thrau commented Sep 25, 2025

Motivation

We had an open issue in our internal issue tracker that was arguing that ApproximateNumberOfMessagesNotVisible was broken because of the same reason of #13196. Turns out it works fine! This just adds aws validated tests to demonstrate that it does.

Changes

  • No functional changes, just adding tests after an investigation

@thrau thrau added aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Sep 25, 2025
@thrau thrau added this to the 4.9 milestone Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 277 tests  ±0   20 536 ✅ ±0   15m 18s ⏱️ -28s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 0cee957. ± Comparison against base commit f93ee95.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 22s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 0cee957. ± Comparison against base commit f93ee95.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 3m 2s ⏱️ - 55m 45s
3 194 tests  - 1 588  3 059 ✅  - 1 387  135 💤  - 201  0 ❌ ±0 
3 196 runs   - 1 588  3 059 ✅  - 1 387  137 💤  - 201  0 ❌ ±0 

Results for commit 0cee957. ± Comparison against base commit f93ee95.

This pull request removes 1592 and adds 4 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_approximate_number_of_messages_not_visible[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_approximate_number_of_messages_not_visible[sqs_query]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fifo_approximate_number_of_messages_not_visible[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fifo_approximate_number_of_messages_not_visible[sqs_query]

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   1h 30m 13s ⏱️ - 1h 8m 18s
3 218 tests  - 1 938  3 086 ✅  - 1 574  132 💤  - 364  0 ❌ ±0 
3 224 runs   - 1 938  3 086 ✅  - 1 574  138 💤  - 364  0 ❌ ±0 

Results for commit 0cee957. ± Comparison against base commit f93ee95.

This pull request removes 1942 and adds 4 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_approximate_number_of_messages_not_visible[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_approximate_number_of_messages_not_visible[sqs_query]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fifo_approximate_number_of_messages_not_visible[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fifo_approximate_number_of_messages_not_visible[sqs_query]

♻️ This comment has been updated with latest results.

baermat
baermat approved these changes Sep 26, 2025
View reviewed changes
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, I would like to clarify something, but if you don't think there is a need to change it it's a go from my side.

@thrau thrau mentioned this pull request Sep 26, 2025
Merged
@thrau thrau merged commit ec023ce into main Sep 26, 2025
39 checks passed
@thrau thrau deleted the sqs-add-visibility-tests branch September 26, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baermat baermat baermat approved these changes

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

No one assigned

Labels

aws:sqs Amazon Simple Queue Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@thrau @baermat