-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
CFn: fix CDK redeploy #13191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFn: fix CDK redeploy #13191
Conversation
Test Results - Alternative Providers573 tests 330 ✅ 26m 4s ⏱️ Results for commit a4d3fa6. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 38m 51s ⏱️ Results for commit a4d3fa6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes.
Nit: The test seems a bit too complex
Motivation
On first deploy of a CDK stack, it does not provide any parameters meaning the defaults are used. However on second deploy it provides the resolved value for the
BootstrapVersionvalue. So on first deploy it uses the default (like/cdk-bootstrap/hnb659fds/version) but on the second it uses the resolved value (e.g.28).Customer reported issue: #13167
Changes
Closes #13167