Skip to content

S3: fix DeleteObjectTagging on current object #13174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bentsku merged 1 commit into from
Sep 23, 2025
Merged

S3: fix DeleteObjectTagging on current object #13174

bentsku merged 1 commit into from
Sep 23, 2025
+49 −15

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Sep 19, 2025

Motivation

As reported in #13162, we had an issue when deleting tags on an versioned object without specifying the version id, meaning we'd target the top of the object stack (current object)

This PR addressed it by using the actual retrieved object version id

Changes

  • update a test to validate the case
  • update which version id is using to delete the object tags

@bentsku bentsku added this to the 4.9 milestone Sep 19, 2025
@bentsku bentsku self-assigned this Sep 19, 2025
@bentsku bentsku added the aws:s3 Amazon Simple Storage Service label Sep 19, 2025
@bentsku bentsku requested a review from k-a-il as a code owner September 19, 2025 23:31
@bentsku bentsku added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Sep 19, 2025
@bentsku bentsku linked an issue Sep 19, 2025 that may be closed by this pull request
bug: DeleteObjectTagging fails on versioned object w/o version-id arg #13162
Closed
1 task
@github-actions
Copy link

github-actions bot commented Sep 19, 2025

S3 Image Test Results (AMD64 / ARM64)

    2 files  ±0    2 suites  ±0   8m 7s ⏱️ -6s
  532 tests ±0  480 ✅ ±0   52 💤 ±0  0 ❌ ±0 
1 064 runs  ±0  960 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit b3a5907. ± Comparison against base commit 0809063.

@github-actions
Copy link

github-actions bot commented Sep 19, 2025

Test Results - Preflight, Unit

22 277 tests  ±0   20 539 ✅ ±0   16m 34s ⏱️ + 1m 20s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit b3a5907. ± Comparison against base commit 0809063.

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 24s ⏱️ -15s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit b3a5907. ± Comparison against base commit 0809063.

@github-actions
Copy link

github-actions bot commented Sep 20, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 39m 22s ⏱️
1 986 tests 1 819 ✅ 167 💤 0 ❌
1 992 runs  1 819 ✅ 173 💤 0 ❌

Results for commit b3a5907.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 19m 57s ⏱️ - 37m 22s
1 962 tests  - 2 705  1 791 ✅  - 2 554  171 💤  - 151  0 ❌ ±0 
1 964 runs   - 2 705  1 791 ✅  - 2 554  173 💤  - 151  0 ❌ ±0 

Results for commit b3a5907. ± Comparison against base commit 0809063.

This pull request removes 2705 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

k-a-il
k-a-il approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@k-a-il k-a-il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bentsku bentsku merged commit 692af03 into main Sep 23, 2025
78 of 80 checks passed
@bentsku bentsku deleted the fix-s3-delete-tagging-versioned branch September 23, 2025 19:08
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-a-il k-a-il k-a-il approved these changes

Assignees

@bentsku bentsku

Labels

aws:s3 Amazon Simple Storage Service docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

bug: DeleteObjectTagging fails on versioned object w/o version-id arg

4 participants

@bentsku @k-a-il @alexrashed