Skip to content

Conversation

@ArthurAkh
Copy link
Contributor

@ArthurAkh ArthurAkh commented Sep 19, 2025

Motivation

The update-test-durations workflow logic now lives in the meta repo as a reusable workflow.
localstack/meta#29
This PR updates localstack to call into the centralized version, reducing duplication and ensuring consistency across community and pro.

Changes

  • Removed the old inline workflow at .github/workflows/update-test-durations.yml.
  • Added a new workflow at the same path that:
    • Calls localstack/meta/.github/workflows/update-test-durations.yml.

@ArthurAkh ArthurAkh self-assigned this Sep 19, 2025
@ArthurAkh ArthurAkh added this to the 4.9 milestone Sep 19, 2025
@ArthurAkh ArthurAkh added docs: skip Pull request does not require documentation changes semver: patch Non-breaking changes which can be included in patch releases labels Sep 19, 2025
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
@ArthurAkh ArthurAkh marked this pull request as ready for review September 26, 2025 12:20
@alexrashed alexrashed modified the milestones: 4.9, Playground Sep 30, 2025
Copy link
Member

@silv-io silv-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge after the release

@silv-io silv-io added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Oct 3, 2025
@silv-io
Copy link
Member

silv-io commented Oct 3, 2025

Maybe we should investigate the conflict here as well before merging /cc @k-a-il

@k-a-il k-a-il self-assigned this Oct 8, 2025
@k-a-il k-a-il requested review from bentsku and removed request for dfangl and dominikschubert October 8, 2025 12:47
Copy link
Contributor

@bentsku bentsku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is still a git conflict to resolve, otherwise the changes looks good 👍 thanks to the simplification you've made!

@k-a-il k-a-il force-pushed the update-test-durations-workflow branch from cc2d0b1 to 6810520 Compare October 9, 2025 08:20
@k-a-il k-a-il force-pushed the update-test-durations-workflow branch from 6810520 to 126a50b Compare October 9, 2025 08:32
@k-a-il k-a-il merged commit 7641d35 into main Oct 9, 2025
5 checks passed
@k-a-il k-a-il deleted the update-test-durations-workflow branch October 9, 2025 10:56
baermat pushed a commit that referenced this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants