DynamoDB: Implement DescribeContributorInsights #13166

aleslash · 2025-09-18T18:34:44Z

Motivation

To get better experience when using localstack with ACK when using dynamodb controller.

Changes

It implements the DescribeContributorInsights function as described in issue #13165

Testing

Run localstack with ack, create any dynamodb resource by applying a manifest like

apiVersion: dynamodb.services.k8s.aws/v1alpha1
kind: Table
metadata:
  name: my-dynamodb-table
spec:
  attributeDefinitions:
    - attributeName: id
      attributeType: S
  keySchema:
    - attributeName: id
      keyType: HASH
  provisionedThroughput:
    readCapacityUnits: 5
    writeCapacityUnits: 5
  tableName: my-dynamodb-table

And verify its status by command:

kubectl get tables.dynamodb.services.k8s.aws

status:

NAME                CLASS   STATUS   SYNCED   AGE
my-dynamodb-table           ACTIVE   True     33m

Closes #13165

localstack-bot · 2025-09-18T18:34:54Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

localstack-bot

Welcome to LocalStack! Thanks for raising your first Pull Request and landing in your contributions. Our team will reach out with any reviews or feedbacks that we have shortly. We recommend joining our Slack Community and share your PR on the #community channel to share your contributions with us. Please make sure you are following our contributing guidelines and our Code of Conduct.

aleslash · 2025-09-19T11:31:55Z

I have read the CLA Document and I hereby sign the CLA

viren-nadkarni

@aleslash Thanks for raising this. Could you please add an AWS-verified parity test to accompany this change? You can read more about them here.

aleslash · 2025-09-23T13:37:34Z

@aleslash Thanks for raising this. Could you please add an AWS-verified parity test to accompany this change? You can read more about them here.

@viren-nadkarni hope that it is ready to go.

viren-nadkarni

Just one change related to transforming, and then we're good to go.

tests/aws/services/dynamodb/test_dynamodb.py

tests/aws/services/dynamodb/test_dynamodb.snapshot.json

tests/aws/services/dynamodb/test_dynamodb.py

viren-nadkarni

Looks good @aleslash, thank you for your contribution to LocalStack!

I'll merge this once the CI run finishes.

localstack-core/localstack/services/dynamodb/provider.py

…at-dynamodb-contributorinsights

aleslash · 2025-09-29T14:34:54Z

@viren-nadkarni can you check again?

aleslash · 2025-09-30T20:04:53Z

@alexrashed @viren-nadkarni since it was crashing just made a refactor on the function to be on the standard implementation
Can you check again?

viren-nadkarni · 2025-10-01T08:32:04Z

@aleslash Sorry for the back and forth. For legacy reasons, we have two separate DynamoDB providers. To clear the tests, all you need to do is add the same handler implementation in this file: localstack-core/localstack/services/dynamodb/v2/provider.py, and we should be able to merge this.

aleslash · 2025-10-01T13:53:47Z

@aleslash Sorry for the back and forth. For legacy reasons, we have two separate DynamoDB providers. To clear the tests, all you need to do is add the same handler implementation in this file: localstack-core/localstack/services/dynamodb/v2/provider.py, and we should be able to merge this.

No problem :)
Just did it
tks @viren-nadkarni and @alexrashed

localstack-bot · 2025-10-01T17:12:03Z

Currently, only patch changes are allowed on main. Your PR labels (semver: minor, review: merge when ready, docs: skip, notes: needed) indicate that it cannot be merged into the main at this time.

aleslash · 2025-10-01T17:16:45Z

@viren-nadkarni @alexrashed just made the corrections (and format style). Need some help with the labels.

alexrashed · 2025-10-06T07:13:18Z

@aleslash @viren-nadkarni it seems like this PR was closed, even though it seems like it was just close to get merged. Was that on purpose?
@aleslash Should we try to take this one over and get it over the line?

aleslash · 2025-10-06T10:18:12Z

@alexrashed since this one was stuck I opened a new one. We can go any way you want.

alexrashed · 2025-10-06T10:37:15Z

Okay, so you are referring to #13220, right? What do you mean with "it was stuck"? What was the issue?

aleslash · 2025-10-06T21:30:14Z

Needed to change back to initial labels or something

alexrashed · 2025-10-07T11:35:27Z

Okay, that's a bit vague 😅 Next time please avoid closing a PR and recreating it, as this makes it complicated to follow the review comments. Feel free to ask any questions on the PR directly. But we'll take it over to #13220 and try to get this over the line from there 😄

aleslash added 2 commits September 18, 2025 15:23

dynamodb describecontributorinsights impl

6f0e2ab

dynamodb describecontributorinsights impl

e45f29d

aleslash requested review from giograno and viren-nadkarni as code owners September 18, 2025 18:34

localstack-bot reviewed Sep 18, 2025

View reviewed changes

aleslash marked this pull request as draft September 18, 2025 18:39

aleslash marked this pull request as ready for review September 18, 2025 18:40

localstack-bot added a commit that referenced this pull request Sep 19, 2025

@aleslash has signed the CLA in #13166

d2ae58a

viren-nadkarni added semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes labels Sep 19, 2025

viren-nadkarni requested changes Sep 19, 2025

View reviewed changes

test: add describe contributor insights test

451363c

aleslash requested review from localstack-bot and viren-nadkarni September 23, 2025 21:26

viren-nadkarni requested changes Sep 24, 2025

View reviewed changes

tests/aws/services/dynamodb/test_dynamodb.py Outdated Show resolved Hide resolved

tests/aws/services/dynamodb/test_dynamodb.snapshot.json Outdated Show resolved Hide resolved

viren-nadkarni reviewed Sep 24, 2025

View reviewed changes

tests/aws/services/dynamodb/test_dynamodb.py Outdated Show resolved Hide resolved

refactor: adjust tests and feature contrib insights

d6354aa

aleslash requested a review from viren-nadkarni September 24, 2025 15:58

viren-nadkarni approved these changes Sep 25, 2025

View reviewed changes

viren-nadkarni changed the title ~~Feat dynamodb contributorinsights~~ DynamoDB: Implement DescribeContributorInsights Sep 25, 2025

viren-nadkarni added review: merge when ready Signals to the reviewer that a PR can be merged if accepted notes: needed Pull request should be mentioned in the release notes labels Sep 25, 2025

viren-nadkarni reviewed Sep 25, 2025

View reviewed changes

localstack-core/localstack/services/dynamodb/provider.py Outdated Show resolved Hide resolved

aleslash added 2 commits September 25, 2025 20:30

Merge branch 'main' of https://github.com/aleslash/localstack into fe…

affb026

…at-dynamodb-contributorinsights

fix: contributor insights signature

3937557

aleslash requested a review from viren-nadkarni September 25, 2025 23:36

alexrashed added this to the 4.10 milestone Sep 30, 2025

refactor: describe contributor insights

3d8878b

feat: describe contributor insights at v2

c6b59b7

chore: fix format style

8adcb22

aleslash closed this Oct 5, 2025

aleslash deleted the feat-dynamodb-contributorinsights branch October 5, 2025 00:42

aleslash restored the feat-dynamodb-contributorinsights branch October 5, 2025 00:43

alexrashed mentioned this pull request Oct 7, 2025

DynamoDB: Implement DescribeContributorInsights #13220

Merged

Uh oh!

DynamoDB: Implement DescribeContributorInsights #13166

DynamoDB: Implement DescribeContributorInsights #13166

Uh oh!

Conversation

aleslash commented Sep 18, 2025 • edited by viren-nadkarni Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Testing

Uh oh!

localstack-bot commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

localstack-bot left a comment

Choose a reason for hiding this comment

Uh oh!

aleslash commented Sep 19, 2025

Uh oh!

viren-nadkarni left a comment

Choose a reason for hiding this comment

Uh oh!

aleslash commented Sep 23, 2025

Uh oh!

viren-nadkarni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

viren-nadkarni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aleslash commented Sep 29, 2025

Uh oh!

aleslash commented Sep 30, 2025

Uh oh!

viren-nadkarni commented Oct 1, 2025

Uh oh!

aleslash commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

localstack-bot commented Oct 1, 2025

Uh oh!

aleslash commented Oct 1, 2025

Uh oh!

alexrashed commented Oct 6, 2025

Uh oh!

aleslash commented Oct 6, 2025

Uh oh!

alexrashed commented Oct 6, 2025

Uh oh!

aleslash commented Oct 6, 2025

Uh oh!

alexrashed commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aleslash commented Sep 18, 2025 •

edited by viren-nadkarni

Loading

localstack-bot commented Sep 18, 2025 •

edited

Loading

aleslash commented Oct 1, 2025 •

edited

Loading