Skip to content

update old references to venv paths #13163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexrashed merged 1 commit into from
Sep 18, 2025
Merged

update old references to venv paths #13163

alexrashed merged 1 commit into from
Sep 18, 2025

Conversation

@alexrashed
Copy link
Member

@alexrashed alexrashed commented Sep 18, 2025

Motivation

With #13037 we upgraded to Python 3.13.
Unfortunately, we have some dev tooling which contains some direct path handling to the venv which we missed to update.
This PR cleans that up. As far as I can tell, there are no other references to python3.11 anymore in the codebase.

Changes

  • Updates venv paths in localstack-core/localstack/dev/ for Python 3.13.

@alexrashed alexrashed added this to the 4.9 milestone Sep 18, 2025
@alexrashed alexrashed added area: ci Running LocalStack in CI environments semver: patch Non-breaking changes which can be included in patch releases review: merge when ready Signals to the reviewer that a PR can be merged if accepted docs: skip Pull request does not require documentation changes labels Sep 18, 2025
@alexrashed alexrashed assigned giograno and unassigned dfangl Sep 18, 2025
@github-actions
Copy link

github-actions bot commented Sep 18, 2025

Test Results - Preflight, Unit

22 172 tests  ±0   20 434 ✅ ±0   15m 4s ⏱️ -53s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit fb3a55e. ± Comparison against base commit 4012f01.

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 15s ⏱️ -11s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit fb3a55e. ± Comparison against base commit 4012f01.

giograno
giograno approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@giograno giograno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 💯

@alexrashed alexrashed merged commit 74a088f into main Sep 18, 2025
45 checks passed
@alexrashed alexrashed deleted the python-3-13-cleanup branch September 18, 2025 14:49
@simonrw simonrw mentioned this pull request Sep 18, 2025
Closed
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giograno giograno giograno approved these changes

@dfangl dfangl Awaiting requested review from dfangl

Assignees

@giograno giograno

Labels

area: ci Running LocalStack in CI environments docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@alexrashed @giograno @dfangl