Skip to content

CFn: add more clarity on logging for unimplemented update methods #13109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonrw merged 1 commit into from
Sep 10, 2025
Merged

CFn: add more clarity on logging for unimplemented update methods #13109

simonrw merged 1 commit into from
Sep 10, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Sep 6, 2025 •
edited
Loading

Motivation

Now that we have announced/released the new CloudFormation engine with #13098, users may be inclined to try updating their stacks more often. We need to be more open and transparent about our update support, so we should tell users when they try to update their resources, but we don't support it.

Changes

  • Log when we don't support an update operation
  • Present link for submitting a feature request

@simonrw simonrw added this to the Playground milestone Sep 6, 2025
@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Sep 6, 2025
@github-actions
Copy link

github-actions bot commented Sep 6, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 124 tests  ±0   20 386 ✅ ±0   6m 22s ⏱️ -5s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d595685. ± Comparison against base commit f31c010.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 6, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   34m 8s ⏱️ - 1h 23m 28s
554 tests  - 4 082  439 ✅  - 3 756  115 💤  - 216  0 ❌  - 110 
556 runs   - 4 082  439 ✅  - 3 756  117 💤  - 216  0 ❌  - 110 

Results for commit d595685. ± Comparison against base commit f31c010.

This pull request removes 4082 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 6, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 15s ⏱️ +10s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d595685. ± Comparison against base commit f31c010.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 6, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   47m 25s ⏱️
578 tests 464 ✅ 114 💤 0 ❌
584 runs  464 ✅ 120 💤 0 ❌

Results for commit d595685.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/log-on-missing-update branch from 55bcba6 to d595685 Compare September 8, 2025 20:14
@simonrw simonrw marked this pull request as ready for review September 8, 2025 20:40
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Test Results - Alternative Providers

553 tests   328 ✅  23m 49s ⏱️
  1 suites  225 💤
  1 files      0 ❌

Results for commit d595685.

@simonrw simonrw added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Sep 10, 2025
@simonrw simonrw merged commit aa8c1ba into main Sep 10, 2025
48 checks passed
@simonrw simonrw deleted the cfn/log-on-missing-update branch September 10, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrw @pinzon