Skip to content

add fixes to CFnV2 for pro pipeline #13045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
simonrw merged 21 commits into from
Sep 4, 2025
Merged

add fixes to CFnV2 for pro pipeline #13045

simonrw merged 21 commits into from
Sep 4, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Aug 21, 2025 •
edited
Loading

Motivation

This PR includes several small fixes that make the Pro CI Pipeline green

Changes

  • change_set_model considers AWS::... references.
  • describer can handle KNOWN_AFTER_APPLY in a Fn::Join
  • AWS_SUFFIX is now LocalStack host and port
  • GetAtt can now obtain lists
  • Template limit is bypassed if the template was pass as URL
  • Consider the possibility of a Custom Resource
  • More overrides in the validator to avoid crashing

@pinzon pinzon mentioned this pull request Aug 21, 2025
Closed
@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 117 tests  ±0   20 379 ✅ ±0   6m 32s ⏱️ -1s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d1c090d. ± Comparison against base commit f74d79b.

♻️ This comment has been updated with latest results.

@pinzon pinzon added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Aug 21, 2025
@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   21m 26s ⏱️ - 1h 21m 54s
555 tests  - 4 077  328 ✅  - 3 861  227 💤  - 216  0 ❌ ±0 
557 runs   - 4 077  328 ✅  - 3 861  229 💤  - 216  0 ❌ ±0 

Results for commit d1c090d. ± Comparison against base commit f74d79b.

This pull request removes 4077 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@pinzon pinzon force-pushed the cfn/v2/test-with-new-provider branch from 14139ea to 08cd525 Compare August 21, 2025 19:19
@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ +4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d1c090d. ± Comparison against base commit f74d79b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   33m 27s ⏱️
579 tests 353 ✅ 226 💤 0 ❌
585 runs  353 ✅ 232 💤 0 ❌

Results for commit d1c090d.

♻️ This comment has been updated with latest results.

@pinzon pinzon changed the title Cfn/v2/test with new provider add fixes to CFnV2 for pro pipeline Aug 21, 2025
@simonrw simonrw marked this pull request as ready for review August 22, 2025 14:58
@simonrw simonrw marked this pull request as draft August 22, 2025 14:58
simonrw
simonrw approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@simonrw simonrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@simonrw simonrw force-pushed the cfn/v2/test-with-new-provider branch from 4d43806 to 67e554c Compare August 22, 2025 20:43
@pinzon pinzon marked this pull request as ready for review September 1, 2025 17:44
@simonrw simonrw force-pushed the cfn/v2/test-with-new-provider branch from 67e554c to 025a7bf Compare September 2, 2025 11:09
@simonrw simonrw force-pushed the cfn/v2/test-with-new-provider branch from 025a7bf to 8d46c88 Compare September 3, 2025 12:14
@pinzon pinzon added this to the 4.8 milestone Sep 3, 2025
@simonrw simonrw merged commit 445c32f into main Sep 4, 2025
40 checks passed
@simonrw simonrw deleted the cfn/v2/test-with-new-provider branch September 4, 2025 10:03
This was referenced Sep 4, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.8

Development

Successfully merging this pull request may close these issues.

3 participants

@pinzon @simonrw