Skip to content

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 19, 2025

Motivation

We need to complete our parity push on supporting the LanguageExtensions transform.

Changes

  • Model the foreach construct so that we get past the modelling phase. We treat this like we treat the Fn::Transform constructs, however to pass the tests we only support them in the resources position
  • Override visit_node_object in the validator to ensure we don't ignore values that evaluate to None
  • Move the setting of the change set update model earlier in the _setup_change_set_model as it's needed in the validator
  • Unskip remaining language extensions tests (5)
    • add an additional field skip in test_transform_foreach_use_case because we now log useful information about unsupported resources in community (AppSync resources)

Next steps

  • Support the Fn::Foreach:: construct at other template positions

@simonrw simonrw added this to the 4.8 milestone Aug 19, 2025
@simonrw simonrw added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 19, 2025
@simonrw simonrw force-pushed the cfn/v2/language-extensions/foreach branch from a9c7dbd to 6b1fbcc Compare August 19, 2025 22:46
@github-actions
Copy link

github-actions bot commented Aug 19, 2025

Test Results - Preflight, Unit

22 144 tests  ±0   20 407 ✅ ±0   6m 23s ⏱️ ±0s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 93a1ec5. ± Comparison against base commit a95c522.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

LocalStack Community integration with Pro

  2 files    2 suites   23m 43s ⏱️
555 tests 330 ✅ 225 💤 0 ❌
557 runs  330 ✅ 227 💤 0 ❌

Results for commit 93a1ec5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 10s ⏱️ -14s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 93a1ec5. ± Comparison against base commit a95c522.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 19, 2025

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   33m 32s ⏱️
579 tests 355 ✅ 224 💤 0 ❌
585 runs  355 ✅ 230 💤 0 ❌

Results for commit 93a1ec5.

♻️ This comment has been updated with latest results.

@simonrw simonrw force-pushed the cfn/v2/language-extensions/length branch from c16a2a3 to c8f7914 Compare August 20, 2025 13:56
@simonrw simonrw force-pushed the cfn/v2/language-extensions/foreach branch from 6b1fbcc to f77b9e0 Compare August 20, 2025 14:00
Base automatically changed from cfn/v2/language-extensions/length to main August 20, 2025 21:05
@simonrw simonrw force-pushed the cfn/v2/language-extensions/foreach branch from 4e32699 to 22e2696 Compare August 20, 2025 21:07
@simonrw simonrw marked this pull request as ready for review August 20, 2025 22:31
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonrw simonrw merged commit 19b301e into main Aug 21, 2025
40 checks passed
@simonrw simonrw deleted the cfn/v2/language-extensions/foreach branch August 21, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants