-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
CFNV2: Implement Fn::ForEach and Fn::ToJsonString for language extensions #13034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a9c7dbd to
6b1fbcc
Compare
LocalStack Community integration with Pro 2 files 2 suites 23m 43s ⏱️ Results for commit 93a1ec5. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 33m 32s ⏱️ Results for commit 93a1ec5. ♻️ This comment has been updated with latest results. |
c16a2a3 to
c8f7914
Compare
6b1fbcc to
f77b9e0
Compare
4e32699 to
22e2696
Compare
pinzon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
We need to complete our parity push on supporting the LanguageExtensions transform.
Changes
Fn::Transformconstructs, however to pass the tests we only support them in the resources positionvisit_node_objectin the validator to ensure we don't ignore values that evaluate toNone_setup_change_set_modelas it's needed in the validatortest_transform_foreach_use_casebecause we now log useful information about unsupported resources in community (AppSync resources)Next steps
Fn::Foreach::construct at other template positions