Skip to content

CFNV2: provide logging for deferred actions and cleanup #13018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinzon merged 6 commits into from
Aug 19, 2025
Merged

CFNV2: provide logging for deferred actions and cleanup #13018

pinzon merged 6 commits into from
Aug 19, 2025

Conversation

@simonrw
Copy link
Contributor

@simonrw simonrw commented Aug 18, 2025 •
edited
Loading

Motivation

While debugging I found it useful to log the deffered actions as they happen along with why the action was being run.

There are also some tests that now pass that haven't been unskipped.

Note

This PR is part of a stack and builds on #13012

Changes

  • Allow the logging of deferred actions at DEBUG level
  • Override select in the describer to propagate known after apply status if the index cannot be accessed
  • unskip three more tests 🎉

@simonrw simonrw added this to the 4.8 milestone Aug 18, 2025
@simonrw simonrw added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 18, 2025
@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 107 tests  ±0   20 372 ✅ ±0   6m 43s ⏱️ +21s
     1 suites ±0    1 735 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 6bd0ec4. ± Comparison against base commit 05caaa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±0    2 suites  ±0   21m 36s ⏱️ +15s
555 tests ±0  330 ✅ ±0  225 💤 ±0  0 ❌ ±0 
557 runs  ±0  330 ✅ ±0  227 💤 ±0  0 ❌ ±0 

Results for commit 6bd0ec4. ± Comparison against base commit 05caaa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ +5s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 6bd0ec4. ± Comparison against base commit 05caaa7.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 18, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files  ±0    5 suites  ±0   33m 32s ⏱️ -2s
579 tests ±0  355 ✅ ±0  224 💤 ±0  0 ❌ ±0 
585 runs  ±0  355 ✅ ±0  230 💤 ±0  0 ❌ ±0 

Results for commit 6bd0ec4. ± Comparison against base commit 05caaa7.

♻️ This comment has been updated with latest results.

@simonrw simonrw mentioned this pull request Aug 18, 2025
Closed
@simonrw simonrw marked this pull request as ready for review August 18, 2025 19:18
@simonrw simonrw added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Aug 19, 2025
@simonrw simonrw assigned simonrw and pinzon and unassigned simonrw Aug 19, 2025
@simonrw simonrw force-pushed the cfn/v2/defer-action-logging-and-cleanup branch from 34df121 to b6e8b5a Compare August 19, 2025 15:30
@simonrw simonrw force-pushed the cfn/v2/url-replacements branch from 5ab71be to ab7dcf3 Compare August 19, 2025 15:30
@simonrw simonrw force-pushed the cfn/v2/defer-action-logging-and-cleanup branch from b6e8b5a to 2e95f36 Compare August 19, 2025 15:59
@simonrw simonrw force-pushed the cfn/v2/url-replacements branch from ab7dcf3 to 8b8386d Compare August 19, 2025 16:00
@simonrw simonrw force-pushed the cfn/v2/url-replacements branch from 8b8386d to 05caaa7 Compare August 19, 2025 16:25
@simonrw simonrw force-pushed the cfn/v2/defer-action-logging-and-cleanup branch from 2e95f36 to 6bd0ec4 Compare August 19, 2025 16:25
pinzon
pinzon approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_preproc.py
def _compute_fn_not(arg: bool) -> bool:
return not arg
def _compute_fn_not(arg: list[bool] | bool) -> bool:
# Is the argument ever a lone boolean?
Copy link
Member

@pinzon pinzon Aug 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the docs define the argument of a Fn::Not is an array. But let's keep the try/except just in case.

@pinzon pinzon merged commit fbf6baf into cfn/v2/url-replacements Aug 19, 2025
38 checks passed
@pinzon pinzon deleted the cfn/v2/defer-action-logging-and-cleanup branch August 19, 2025 18:01
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: provide logging for deferred actions and cleanup (#13018)
dc78607
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: provide logging for deferred actions and cleanup (#13018)
f469a5b
simonrw added a commit that referenced this pull request Aug 19, 2025
@simonrw
CFNV2: provide logging for deferred actions and cleanup (#13018)
56690b7
@simonrw simonrw mentioned this pull request Sep 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert

Assignees

@pinzon pinzon

Labels

review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.8

Development

Successfully merging this pull request may close these issues.

3 participants

@simonrw @pinzon