CFNV2: finish URL replacements for API Gateway #13012
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
semver: minor
simonrw
changed the title
LocalStack Community integration with Pro 2 files 2 suites 21m 41s ⏱️ Results for commit f469a5b. ♻️ This comment has been updated with latest results. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 33m 41s ⏱️ Results for commit f469a5b. ♻️ This comment has been updated with latest results. |
simonrw
force-pushed
the
cfn/v2/implement-no-echo
branch
from
ca51a61 to
c4a009c
Compare
simonrw
force-pushed
the
cfn/v2/url-replacements
branch
2 times, most recently
from
ab7dcf3 to
8b8386d
Compare
simonrw
force-pushed
the
cfn/v2/implement-no-echo
branch
2 times, most recently
from
2db9745 to
416e56c
Compare
simonrw
force-pushed
the
cfn/v2/url-replacements
branch
from
8b8386d to
05caaa7
Compare
Base automatically changed from
cfn/v2/implement-no-echo
to
cfn/v2/fix-remaining-transform-tests
August 19, 2025 18:09
pinzon
approved these changes
Aug 19, 2025
Member
pinzon
left a comment
pinzon
left a comment
There was a problem hiding this comment.
This PR includes the changes from 2 others (Implement NoEcho and Improve Logging) which makes it a bit harder review.
Apart from that there is just one suggestion to consider before merging.
localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_executor.py
Outdated
Show resolved
Hide resolved
simonrw
force-pushed
the
cfn/v2/fix-remaining-transform-tests
branch
from
a7f4742 to
976fad7
Compare
simonrw
removed
the
review: merge when ready
simonrw
force-pushed
the
cfn/v2/fix-remaining-transform-tests
branch
from
976fad7 to
ab6f2d7
Compare
simonrw
force-pushed
the
cfn/v2/url-replacements
branch
from
fbf6baf to
5b7e8d4
Compare
simonrw
force-pushed
the
cfn/v2/fix-remaining-transform-tests
branch
from
ab6f2d7 to
f9e466d
Compare
simonrw
force-pushed
the
cfn/v2/url-replacements
branch
from
2311ae0 to
f469a5b
Compare
simonrw
added a commit
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
One remaining case where we replace API Gateway urls with LocalStack URLs remains.
Note: this is needed for APIGWv1 because the URL is not an output of the API so we have to adjust it in CFn :(
Note
This forms a stack on top of #13011
Changes