fix port subrange from subclass #13001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutierMat
added
area: docker
dfangl
approved these changes
Aug 13, 2025
Member
dfangl
left a comment
dfangl
left a comment
There was a problem hiding this comment.
LGTM! Just a minor suggestion, but otherwise definitely makes sense!
|
|
||
| port_range = PortRange(start, end) | ||
| # ensures that we return an instance of a subclass | ||
| port_range = self.__class__(start, end) |
Member
There was a problem hiding this comment.
Suggested change
| port_range = self.__class__(start, end) | |
| port_range = type(self)(start, end) |
suggestion: I think this is more idiomatic than accessing the dunder class method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR aims to fix
PortRange.subrangeto return an instance of a subclass instead of harcodingPortRange.While working on Elasticache and MemoryDb in container, I realised it was not possible to create more than 1 Redis/Valkey container at once. This was due to
PortRangenot validating that the port is available on the host. Using_DockerPortRangewould fix the issue, however thesubrangemethod would return an instance ofPortRangeinstead of_DockerPortRange.Changes
self.__class__to retrieve the instance's class