-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
CFNV2: handle AWS::NoValue #13000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFNV2: handle AWS::NoValue #13000
Conversation
Use a regex to handle the parameter types and whether they are a list type or not
Test Results (amd64) - Integration, Bootstrap 5 files ± 0 5 suites ±0 2h 23m 40s ⏱️ + 1h 50m 5s Results for commit 1fe4b7c. ± Comparison against base commit 9c7fd42. ♻️ This comment has been updated with latest results. |
LocalStack Community integration with Pro 2 files ± 0 2 suites ±0 1h 43m 18s ⏱️ + 1h 21m 15s Results for commit 1fe4b7c. ± Comparison against base commit 9c7fd42. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change 👍
Nit: it would be nice to see a test for the case when AWS::NoValue is used in a Fn::Sub.
31809f2 to
1fe4b7c
Compare
If I try to use an Resources:
AnotherParameter:
Type: AWS::SSM::Parameter
Properties:
Type: String
Value:
Fn::Sub:
- "My great value ${foo}"
- foo: !Ref AWS::NoValue
I get the following error: |
Motivation
We currently model the
AWS::NoValueintrinsic value by returningNone, however this is not the right approach. We already perform lots of filtering in e.g.visit_node_propertiesforNothingvalues, andAWS::NoValuehas a similar place as returningNothing.Changes
Refresolving if the arguments areAWS::NoValueand returnNothingin its place