CFNv2: support resolve:ssm: and resolve:secretsmanager: strings #12965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
LocalStack Community integration with Pro 2 files 2 suites 22m 17s ⏱️ Results for commit 7b1baa1. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 33m 46s ⏱️ Results for commit 7b1baa1. |
simonrw
added
the
review: merge when ready
pinzon
approved these changes
Aug 6, 2025
Member
pinzon
left a comment
pinzon
left a comment
There was a problem hiding this comment.
LGTM. It would be nice to have a test that asserts the Not happy path of the resolving. But let's handle that in the future.
Comment on lines
+70
to
+74
| kwargs = {} # optional args for get_secret_value | ||
| if version_id: | ||
| kwargs["VersionId"] = version_id | ||
| if version_stage: | ||
| kwargs["VersionStage"] = version_stage |
Member
There was a problem hiding this comment.
python complain: there should be a more pythonic way to handle this.
Contributor
Author
There was a problem hiding this comment.
Hehe this came from @dominikschubert in 2021!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The V2 engine does not currently support resolving dynamic parameter values, e.g.
Changes