Skip to content

Bump moto-ext to 5.1.11.post1 #12964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
viren-nadkarni merged 19 commits into from
Aug 25, 2025
Merged

Bump moto-ext to 5.1.11.post1 #12964

viren-nadkarni merged 19 commits into from
Aug 25, 2025

Conversation

@viren-nadkarni
Copy link
Member

@viren-nadkarni viren-nadkarni commented Aug 6, 2025 •
edited
Loading

Summary

This PR bumps moto-ext to 5.1.11.post1

Since the previous bump, Moto migrated EC2, Autoscailng, CloudWatch, IAM, SES, Redshift, ELB and EMR to the new response serialiser. This broke several patches and tests which had to be fixed, thus the long wait between the bumps.

Contains:

To do

Closes PNX-3

@viren-nadkarni viren-nadkarni self-assigned this Aug 6, 2025
@viren-nadkarni viren-nadkarni added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 144 tests  ±0   20 407 ✅ ±0   6m 17s ⏱️ -14s
     1 suites ±0    1 737 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit f81ee66. ± Comparison against base commit 00dd0a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 19s ⏱️ +57s
4 632 tests ±0  4 189 ✅  - 1  443 💤 +1  0 ❌ ±0 
4 634 runs  ±0  4 189 ✅  - 1  445 💤 +1  0 ❌ ±0 

Results for commit f81ee66. ± Comparison against base commit 00dd0a5.

This pull request skips 1 test. 
tests.aws.services.secretsmanager.test_secretsmanager.TestSecretsManager ‑ test_http_put_secret_value_with_duplicate_client_request_token

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

    2 files    2 suites   8m 14s ⏱️
  517 tests 467 ✅  50 💤 0 ❌
1 034 runs  934 ✅ 100 💤 0 ❌

Results for commit f81ee66.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 9s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit f81ee66. ± Comparison against base commit 00dd0a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±0      5 suites  ±0   2h 21m 16s ⏱️ + 1m 10s
5 003 tests ±0  4 402 ✅  - 1  601 💤 +1  0 ❌ ±0 
5 009 runs  ±0  4 402 ✅  - 1  607 💤 +1  0 ❌ ±0 

Results for commit f81ee66. ± Comparison against base commit 00dd0a5.

This pull request skips 1 test. 
tests.aws.services.secretsmanager.test_secretsmanager.TestSecretsManager ‑ test_http_put_secret_value_with_duplicate_client_request_token

♻️ This comment has been updated with latest results.

@viren-nadkarni viren-nadkarni added the docs: skip Pull request does not require documentation changes label Aug 21, 2025
@github-actions
Copy link

github-actions bot commented Aug 22, 2025

Test Results (MA/MR) - Preflight, Unit

22 144 tests   20 407 ✅  6m 22s ⏱️
     1 suites   1 737 💤
     1 files         0 ❌

Results for commit ff5f418.

@github-actions
Copy link

github-actions bot commented Aug 22, 2025

Test Results (amd64, MA/MR) - Acceptance

7 tests   5 ✅  3m 17s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit ff5f418.

@github-actions
Copy link

github-actions bot commented Aug 22, 2025

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files      5 suites   2h 20m 40s ⏱️
4 990 tests 4 398 ✅ 592 💤 0 ❌
4 996 runs  4 398 ✅ 598 💤 0 ❌

Results for commit ff5f418.

@viren-nadkarni viren-nadkarni changed the title Bump moto-ext to 5.1.9.post1 Bump moto-ext to 5.1.11.post1 Aug 25, 2025
@coveralls
Copy link

coveralls commented Aug 25, 2025

Coverage Status

coverage: 82.64% (-4.2%) from 86.837%
when pulling f81ee66 on bump-moto-ext
into 00dd0a5 on main.

@viren-nadkarni viren-nadkarni marked this pull request as ready for review August 25, 2025 07:39
alexrashed
alexrashed approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for following up on this big moto upgrade! 🦸🏽
The changes are looking good to me, I only had a question on a skipped test. Something that we can just clarify in the thread and then merge the PR! :shipit:

FYI: The coveralls check is only failing because of an issue with the pipeline / reporting. This should already be fixed for future PRs (with configuration changes on the Coveralls platform).

@viren-nadkarni viren-nadkarni merged commit d89864a into main Aug 25, 2025
50 of 51 checks passed
@viren-nadkarni viren-nadkarni deleted the bump-moto-ext branch August 25, 2025 09:00
@alexrashed alexrashed mentioned this pull request Aug 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees

@viren-nadkarni viren-nadkarni

Labels

docs: skip Pull request does not require documentation changes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: Unable to verify creation of SES configuration set event destination

4 participants

@viren-nadkarni @coveralls @alexrashed