Skip to content

add java 24 support in java installer for trino #12963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
macnev2013 merged 2 commits into from
Aug 7, 2025
Merged

add java 24 support in java installer for trino #12963

macnev2013 merged 2 commits into from
Aug 7, 2025

Conversation

@macnev2013
Copy link
Contributor

@macnev2013 macnev2013 commented Aug 6, 2025 •
edited
Loading

Motivation

This PR adds support for Java version 24, which is required for upgrading Trino server from version 389 to 476. Additionally, this PR refactors the module installation commands to improve code maintainability and readability.

Changes

  • Addition of new java version 24
  • Refactored application for more readable module installation command generation
  • Addition of jdk.incubator.vector java module for java 24 for trino

Testing

  • Existing tests are passing which signifies the existing Java installations are not affected.
  • java 24 installer is used in Trino in pro which was tested locally.

@macnev2013 macnev2013 added the semver: patch Non-breaking changes which can be included in patch releases label Aug 6, 2025
@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 063 tests  ±0   20 329 ✅ ±0   6m 18s ⏱️ -1s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c300829. ± Comparison against base commit 29690c2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 7s ⏱️ -12s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c300829. ± Comparison against base commit 29690c2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 20m 42s ⏱️
4 967 tests 4 385 ✅ 582 💤 0 ❌
4 973 runs  4 385 ✅ 588 💤 0 ❌

Results for commit c300829.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 44m 6s ⏱️ + 2m 38s
4 608 tests +1  4 178 ✅ +1  430 💤 ±0  0 ❌ ±0 
4 610 runs  +1  4 178 ✅ +1  432 💤 ±0  0 ❌ ±0 

Results for commit c300829. ± Comparison against base commit 29690c2.

♻️ This comment has been updated with latest results.

@macnev2013 macnev2013 changed the title added java version upgrade to support trino add java version upgrade to support trino Aug 7, 2025
@macnev2013 macnev2013 changed the title add java version upgrade to support trino add java 24 support in java installer for trino Aug 7, 2025
@macnev2013 macnev2013 marked this pull request as ready for review August 7, 2025 05:56
@macnev2013 macnev2013 requested a review from alexrashed as a code owner August 7, 2025 05:56
alexrashed
alexrashed approved these changes Aug 7, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean! 💯
I think we should generally start upgrading the Java version of basically all our backends. This here is a great start, and will pave the way for an upgrade of the backend of Athena! ⬆️

@macnev2013 macnev2013 merged commit 2d08a27 into main Aug 7, 2025
52 checks passed
@macnev2013 macnev2013 deleted the upgrade/trino branch August 7, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed approved these changes

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@macnev2013 @alexrashed