Skip to content

add support for nested Fn in FnSelect for CFn #12955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pinzon merged 2 commits into from
Aug 11, 2025
Merged

add support for nested Fn in FnSelect for CFn #12955

pinzon merged 2 commits into from
Aug 11, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Aug 5, 2025

Motivation

As mentioned in the issue #12775. LocalStack's CFn engine was incapable of resolving a FnSelect that had another Fn as second parameter. This PR fixes that.

Changes

  • Resolve if Options parameter is another function.

Testing

  • New AWS validated test

@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 063 tests  ±0   20 329 ✅ ±0   6m 15s ⏱️ -22s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit c03b9ff. ± Comparison against base commit f0685555.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit c03b9ff. ± Comparison against base commit f0685555.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 22m 9s ⏱️
4 983 tests 4 394 ✅ 589 💤 0 ❌
4 989 runs  4 394 ✅ 595 💤 0 ❌

Results for commit c03b9ff.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 5, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 42m 53s ⏱️ -35s
4 624 tests +1  4 187 ✅ +1  437 💤 ±0  0 ❌ ±0 
4 626 runs  +1  4 187 ✅ +1  439 💤 ±0  0 ❌ ±0 

Results for commit c03b9ff. ± Comparison against base commit f0685555.

♻️ This comment has been updated with latest results.

@pinzon pinzon added the semver: patch Non-breaking changes which can be included in patch releases label Aug 5, 2025
@pinzon pinzon marked this pull request as ready for review August 8, 2025 23:17
@pinzon pinzon merged commit 853032a into main Aug 11, 2025
40 checks passed
@pinzon pinzon deleted the cp/cfn/fix/fn-select-fn-mapp branch August 11, 2025 18:22
@simonrw simonrw mentioned this pull request Aug 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonrw simonrw simonrw approved these changes

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pinzon @simonrw