Skip to content

SQS: Allow usage of message-group-id param when using a Fair Queue #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nik-localstack merged 1 commit into from
Jul 30, 2025
Merged

SQS: Allow usage of message-group-id param when using a Fair Queue #12930

nik-localstack merged 1 commit into from
Jul 30, 2025

Conversation

@nik-localstack
Copy link
Contributor

@nik-localstack nik-localstack commented Jul 30, 2025

Motivation

Closes #12898

Changes

Allows sending message in an SQS using --message-group-id parameter

@nik-localstack nik-localstack added this to the 4.8 milestone Jul 30, 2025
@nik-localstack nik-localstack self-assigned this Jul 30, 2025
@nik-localstack nik-localstack added aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases labels Jul 30, 2025
@github-actions
Copy link

github-actions bot commented Jul 30, 2025

Test Results - Preflight, Unit

21 991 tests  ±0   20 257 ✅ ±0   6m 24s ⏱️ ±0s
     1 suites ±0    1 734 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 7ca0ff5. ± Comparison against base commit d76a019.

@github-actions
Copy link

github-actions bot commented Jul 30, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 5s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 7ca0ff5. ± Comparison against base commit d76a019.

@github-actions
Copy link

github-actions bot commented Jul 30, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 31m 48s ⏱️
3 186 tests 3 054 ✅ 132 💤 0 ❌
3 194 runs  3 056 ✅ 138 💤 0 ❌

Results for commit 7ca0ff5.

@github-actions
Copy link

github-actions bot commented Jul 30, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   1h 3m 20s ⏱️ - 39m 40s
3 164 tests  - 1 318  3 030 ✅  - 1 125  134 💤  - 193  0 ❌ ±0 
3 166 runs   - 1 318  3 030 ✅  - 1 125  136 💤  - 193  0 ❌ ±0 

Results for commit 7ca0ff5. ± Comparison against base commit d76a019.

This pull request removes 1327 and adds 9 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fair_queue_with_message_group_id[sqs]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_fair_queue_with_message_group_id[sqs_query]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_message_deduplication_id_invalid[empty]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_message_deduplication_id_invalid[spaces]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_message_deduplication_id_invalid[too_long]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_message_deduplication_id_success
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_send_message_to_standard_queue_with_invalid_message_group_id[empty]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_send_message_to_standard_queue_with_invalid_message_group_id[spaces]
tests.aws.services.sqs.test_sqs.TestSqsProvider ‑ test_send_message_to_standard_queue_with_invalid_message_group_id[too_long]

@coveralls
Copy link

coveralls commented Jul 30, 2025

Coverage Status

coverage: 75.103% (+23.7%) from 51.37%
when pulling 7ca0ff5 on sqs/fix-fair-queue-message-group-id
into d76a019 on main.

@nik-localstack nik-localstack marked this pull request as ready for review July 30, 2025 11:20
baermat
baermat approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@baermat baermat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for tackling this, I was not aware of this change. For anyone interested
https://aws.amazon.com/about-aws/whats-new/2025/07/amazon-sqs-introduces-fair/?utm_source=chatgpt.com

@nik-localstack nik-localstack merged commit 476e7f3 into main Jul 30, 2025
45 checks passed
@nik-localstack nik-localstack deleted the sqs/fix-fair-queue-message-group-id branch July 30, 2025 12:15
@bentsku bentsku mentioned this pull request Aug 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baermat baermat baermat approved these changes

@thrau thrau Awaiting requested review from thrau thrau is a code owner

@gregfurman gregfurman Awaiting requested review from gregfurman gregfurman is a code owner

Assignees

@nik-localstack nik-localstack

Labels

aws:sqs Amazon Simple Queue Service semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.8

Development

Successfully merging this pull request may close these issues.

bug: localstack standard sqs queue doens't support passing "MessageGroupId" for Fair Queues feature

4 participants

@nik-localstack @coveralls @baermat