pre-commit: validate json files on commit #12925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrw
added
the
semver: patch
simonrw
requested review from
alexrashed,
bentsku,
k-a-il,
sannya-singal and
silv-io
as code owners
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 20m 20s ⏱️ Results for commit 84357fe. |
alexrashed
approved these changes
Jul 30, 2025
Member
alexrashed
left a comment
alexrashed
left a comment
There was a problem hiding this comment.
I think this is a nice convenience feature which should not have any impact on performance (since pre-commit only checks files in the commit). 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes I have to update snapshot files manually. For example when moving tests from one file to another. I regularly mess up the syntax so the tests fail once CI has run.
We have a series of pre-commit hooks that are run before code is committed. As part of the "push left" initiative (of which LocalStack itself is part!) we should be able to catch these checks before committing code, and definitely before pushing code up to GitHub.
Changes
check-jsonhook in our pre-commit configuration file